Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cargo - Improve config and fnc_getNameItem #8777

Merged
merged 5 commits into from
Jan 30, 2022
Merged

Cargo - Improve config and fnc_getNameItem #8777

merged 5 commits into from
Jan 30, 2022

Conversation

LinkIsGrim
Copy link
Contributor

When merged this pull request will:

  • Title.
  • Block renaming 300l fuel container.
  • Change config macro to GVAR from EGVAR.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@mharis001 mharis001 added the kind/enhancement Release Notes: **IMPROVED:** label Jan 15, 2022
@mharis001 mharis001 added this to the 3.14.2 milestone Jan 15, 2022
@Drofseh
Copy link
Contributor

Drofseh commented Jan 15, 2022

Being able to rename statics to indicate ammo state is kind of nice

@rautamiekka
Copy link
Contributor

Being able to rename statics to indicate ammo state is kind of nice

Agree.

@LinkIsGrim
Copy link
Contributor Author

Discussion status?

@veteran29
Copy link
Member

What about doing it similarly to bodybags?
NameOfStaticWeapon (Custom name)

@Drofseh
Copy link
Contributor

Drofseh commented Jan 16, 2022

What about doing it similarly to bodybags? NameOfStaticWeapon (Custom name)

That sounds like a good solution

@LinkIsGrim
Copy link
Contributor Author

That's current behavior, so /shrug. Reverting added noRename properties, keeping the macros and improving fnc_getNameItem.

@LinkIsGrim LinkIsGrim changed the title Cargo - Block renaming static weapons Cargo - Improve config and fnc_getNameItem Jan 26, 2022
@PabstMirror PabstMirror merged commit 1013e1a into acemod:master Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PabstMirror PabstMirror PabstMirror approved these changes

@veteran29 veteran29 Awaiting requested review from veteran29

@mharis001 mharis001 Awaiting requested review from mharis001

Assignees
No one assigned
Labels
kind/enhancement Release Notes: **IMPROVED:** status/discussion
Projects
None yet
Milestone
3.15.0
Development

Successfully merging this pull request may close these issues.
6 participants
@LinkIsGrim @Drofseh @rautamiekka @veteran29 @PabstMirror @mharis001