Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map Tools - Add Vernier Scale and Improve resolution #8674

Merged
merged 6 commits into from
Jul 28, 2023

Conversation

LorenLuke
Copy link
Contributor

@LorenLuke LorenLuke commented Nov 10, 2021

When merged this pull request will:

  • Adds a Vernier scale (2 mils) to the maptools, allowing visual use for slightly more accurate reading of milliradian directions.

@LorenLuke LorenLuke changed the title Adds 5mil Vernier scale to large and small maptools. Maptools - Adds 5mil Vernier scale to large and small maptools Nov 10, 2021
@LorenLuke LorenLuke changed the title Maptools - Adds 5mil Vernier scale to large and small maptools WIP Maptools - Adds 5mil Vernier scale to large and small maptools Nov 10, 2021
@LorenLuke LorenLuke changed the title WIP Maptools - Adds 5mil Vernier scale to large and small maptools Maptools - Adds 5mil Vernier scale to large and small maptools Nov 10, 2021
@LorenLuke LorenLuke changed the title Maptools - Adds 5mil Vernier scale to large and small maptools Maptools - Adds 4mil Vernier scale to large and small maptools Nov 10, 2021
@veteran29
Copy link
Member

Needs to make sure we're using only the highest mip of the texture to prevent blurry maptools on lower texture settings. (https://github.com/arma3/MipMapTool)

@bux
Copy link
Member

bux commented Nov 10, 2021

Could you add an example image to the description please :)

@LorenLuke
Copy link
Contributor Author

Worth noting, the actual point of rotation is ever so slightly offset, so sometimes the scale will not align exactly as it should, but it still will be read within +/-3 mils or so. Which is no more than 12 meters error at 4km, and still aligns to compass fine.

Center section (basically identical to both maptools):
Center
Large map tool oriented north:
Large
Small maptool oriented north:
Small
5468:
5468
3542:
3542
1652:
1652
4748:
4748

@bux
Copy link
Member

bux commented Nov 11, 2021

Could you try using another color than cyan. Imho it is hard to read, especially on the gray background.

@LorenLuke
Copy link
Contributor Author

@bux

Could you try using another color than cyan. Imho it is hard to read, especially on the gray background.

Are you referring to the numbers or the lines, or both? I personally fine the lines fine, and would like to keep them that color, as it contrasts to the white, the black, and the red, but if you want to have the numbers changed, I could do that easily (my only concern with those small numbers being black is associating them with the cyan lines).

If you have another color you believe to work better for either the numbers or the lines, I'm more than willing to hear what you have in mind.

@Drofseh
Copy link
Contributor

Drofseh commented Nov 11, 2021

I really don't like the cyan colour either. I think we should stay with red or black, probably red in this case.

@LorenLuke
Copy link
Contributor Author

LorenLuke commented Nov 11, 2021

Not committed at time of posting, but... here's it in red, and not on the VR map.

1874:
1874
2686:
2686
5318:
5318

EDIT: I dunno why, but it seems that Git don't like the second image.
https://media.discordapp.net/attachments/296187009524039692/908285834132881418/unknown.png

@jonpas jonpas added the kind/feature Release Notes: **ADDED:** label Nov 11, 2021
@jonpas jonpas added this to the 3.15.0 milestone Nov 11, 2021
@LupusTheCanine
Copy link
Contributor

IMHO red looks way more readable.

@LorenLuke LorenLuke changed the title Maptools - Adds 4mil Vernier scale to large and small maptools Maptools - Adds 2mil Vernier scale to large and small maptools Nov 11, 2021
@LorenLuke
Copy link
Contributor Author

Ready in red.

@dedmen
Copy link
Contributor

dedmen commented Nov 17, 2021

The texture is just 2k, I think it might make sense here to go 4k for this?

@LorenLuke
Copy link
Contributor Author

LorenLuke commented Nov 17, 2021

@dedmen

4k

While I don't disagree, my general workflow has been

  • paa to png
  • edit in photoshop
  • save as interlaced png
  • img to paa

Because of this I didn't want to mess with scaling at all in case it threw it off, and am unsure how to go about making a higher resolution image while guaranteeing the whole thing isn't just going to be twice as big in scale as the original.

Edit: Nevermind, I see the autoscaling code. I'll try and give the tool a 4K touch-up in the coming days.

@PabstMirror PabstMirror modified the milestones: 3.15.1, Ongoing May 24, 2022
@LinkIsGrim LinkIsGrim changed the title Maptools - Adds 2mil Vernier scale to large and small maptools Map Tools - Add Vernier Scale and Improve resolution Jul 28, 2023
@LinkIsGrim LinkIsGrim removed this from the Ongoing milestone Jul 28, 2023
@LinkIsGrim LinkIsGrim added this to the 3.16.0 milestone Jul 28, 2023
@LinkIsGrim LinkIsGrim merged commit 1855114 into acemod:master Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Release Notes: **ADDED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants