Magazine Repack - Add setting & hint for repacking loaded magazines

[LinkIsGrim]

When merged this pull request will:

• Title.
• Close Magazine Repack - When repacking a weapon can be unloaded without the player knowing #8471.

[Drofseh]

I'm happy with this solution.
I don't think there is a need for 0,1,2 though, just bool should be fine and always show the hint if it's turned on.
I think repackLoadedMagazines would be clearer than repackEquippedMagazines, but whatever.

[LinkIsGrim]

Went with equipped because technically any magazine with ammo in it can be called 'loaded'. Equipped can only mean it's currently in use.

[Drofseh]

equipped to me sounds like any magazine in my equipent/inventory
eg. "I am equipped with 10 magazines and a rifle."

Since arma doesn't have unloaded magazines, I still think repackLoadedMagazines sounds clearer

[Dabako]

I'm happy with this solution. I don't think there is a need for 0,1,2 though, just bool should be fine and always show the hint if it's turned on. I think repackLoadedMagazines would be clearer than repackEquippedMagazines, but whatever.

Do I understand that right. If there are no three options that would mean there is only the option to either don't repack the magazin that is loaded or do it with an hint? I am personally liking that touch that when you forget to reload your gun after repacking you are just without bullets. So it would be nice to have the option to repack that mag without a hint.

[Drofseh]

Right now there are three settings, "no unload", "no hint", "hint".

Because the player never sees their weapon get unloaded (the bullets just magically disappear), I think the "no hint" option is a bad idea. This is the current situation that I want to avoid.

If you really really want it though, I guess it's ok if it's included, but personally I think it's a bug not a feature.

[Dabako]

Yeah it would really be nicer if there would be an animation playing unloading the weapon so people could tell that you gun got unloaded. (I think to add something like an unloading animation would be a bit to complicated for this problem?)

But I was kinda happy that I unloaded it and that I got punished for not reloading my weapon. I understand that this behaviour can be seen as a bug. (What it kinda seems to be without an animation).
I think it would be nice to give players that type of option to make it with our without hints because I personally just want as few hints as possible in my gameplay experience.

But if it would make problems to leave the 3 options in, it would also be okay for me. Just wanted to show that there could be people who like this feature (bug).

[jonpas]

Since arma doesn't have unloaded magazines, I still think repackLoadedMagazines sounds clearer

Agreed.

If you really really want it though, I guess it's ok if it's included, but personally I think it's a bug not a feature.

Not a bug, just a missing animation as @Dabako said. I can see why it can be seen as a bug though, and that could be another solution in addition to this PR. I am ok with removing the "no hint" option for now for the sake of clarity.