Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Medical GUI - Add setting to show Damage #8444

Merged
merged 10 commits into from
Jun 30, 2023
Merged

Medical GUI - Add setting to show Damage #8444

merged 10 commits into from
Jun 30, 2023

Conversation

LinkIsGrim
Copy link
Contributor

@LinkIsGrim LinkIsGrim commented Sep 17, 2021 •
edited
Loading

When merged this pull request will:

  • Add Setting & Injury List entry for displaying qualitative % of Damage Threshold taken on a given body part.
  • Change hardcoded pain tooltip values in updateInjuryList to painUnconsciousThreshold variable.
  • Take Damage Threshold into account when displaying body part damage color.

Screenshot:
107410_20230628165027_1

@LinkIsGrim
use pain variable for severe pain and use threshold in damage color c…
4654580 
…alculation

show % of damage threshold in medical menu
@LinkIsGrim LinkIsGrim changed the title Medical GUI - Show % of Damage Threshold in Medical Menu Medical GUI - Show % of Damage Threshold taken in Medical Menu Sep 17, 2021
@LinkIsGrim LinkIsGrim marked this pull request as ready for review September 17, 2021 04:04
@BrettMayson
Copy link
Member

Setting for this? I personally would not want it

@LinkIsGrim LinkIsGrim marked this pull request as draft September 17, 2021 09:58
@LinkIsGrim LinkIsGrim changed the title Medical GUI - Show % of Damage Threshold taken in Medical Menu Medical GUI - Add Damage Taken Tooltip Sep 17, 2021
@LinkIsGrim LinkIsGrim changed the title Medical GUI - Add Damage Taken Tooltip Medical GUI - Add Damage Tooltip Sep 17, 2021
@LinkIsGrim LinkIsGrim marked this pull request as ready for review September 17, 2021 10:27
BrettMayson
BrettMayson requested changes Sep 20, 2021
View reviewed changes
addons/medical_gui/initSettings.sqf Outdated Show resolved Hide resolved
@LinkIsGrim LinkIsGrim changed the title Medical GUI - Add Damage Tooltip Medical GUI - Add setting to show Damage Sep 20, 2021
BrettMayson
BrettMayson approved these changes Aug 16, 2022
View reviewed changes
Copy link
Member

@BrettMayson BrettMayson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, fractures do seem to send anything to 100% damage.

@veteran29 veteran29 self-requested a review August 16, 2022 13:57
@veteran29 veteran29 added the kind/feature Release Notes: **ADDED:** label Aug 16, 2022
@LinkIsGrim LinkIsGrim requested a review from veteran29 June 24, 2023 05:53
@LinkIsGrim LinkIsGrim requested a review from BrettMayson June 27, 2023 00:00
@LinkIsGrim LinkIsGrim added this to the 3.16.0 milestone Jun 30, 2023
@LinkIsGrim LinkIsGrim merged commit ba4fcf6 into acemod:master Jun 30, 2023
@MiszczuZPolski MiszczuZPolski mentioned this pull request Oct 19, 2023
Merged
@Rythoka
Copy link

Rythoka commented Oct 25, 2023

Just an opinion, but the terminology used here isn't great and I don't think it would be immediately obvious to most people what the difference between "major" and "severe" is. Also, "chronic" has nothing to do with severity, it just means that a conditions is persistent or long-lasting. "Chronic trauma" would be something closer to Carpal Tunnel Syndrome than a gunshot wound.

IMO a better set of categories would be "Minor," "Moderate," "Severe," and "Critical."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrettMayson BrettMayson BrettMayson approved these changes

@veteran29 veteran29 Awaiting requested review from veteran29

Assignees
No one assigned
Labels
kind/feature Release Notes: **ADDED:**
Projects
None yet
Milestone
3.16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@LinkIsGrim @BrettMayson @Rythoka @veteran29