Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dragging - Allow run when carrying light-weight objects #8338

Merged
merged 4 commits into from
Jun 28, 2023

Conversation

Dystopian
Copy link
Contributor

When merged this pull request will:

  • title.

Only sprint is blocked for light-weight objects.
MAX_WEIGHT_RUN==50 is enough to carry 1 MX rifle or about 10 MX magazines or 1 AT rocket or 2 HE rockets.

Should be merged alongside #6029 but no problems without it.

@mharis001 mharis001 added the kind/enhancement Release Notes: **IMPROVED:** label Jul 25, 2021
@mharis001 mharis001 added this to the 3.14.0 milestone Jul 25, 2021
@shukari
Copy link
Contributor

shukari commented Jul 26, 2021

Is there a possibility to get this not as define... so other people can change it in the mission?

@Dystopian
Copy link
Contributor Author

Is there a possibility to get this not as define... so other people can change it in the mission?

can do like here

ACE_maxWeightCarry = 600;

@shukari
Copy link
Contributor

shukari commented Jul 26, 2021

That would be great. It is a shame that so many things are now marcos so it can't be changed easy.

@Drofseh
Copy link
Contributor

Drofseh commented Jul 26, 2021

Having it as a setting would be nice

@Dystopian
Copy link
Contributor Author

Having it as a setting would be nice

This I can't do, sorry.

@severgun
Copy link
Contributor

severgun commented Jul 26, 2021

This I can't do, sorry.

Something like that in XEH_preInit.sqf and corresponding stringtables entries.

[
    "ACE_maxWeightCarry", "SLIDER",
    [LSTRING(maxWeightCarry_displayName), LSTRING(maxWeightCarry_description)],
    LSTRING(weight_category),
    [0,3000,600,0],
    true
] call CBA_fnc_addSetting;

[
    QGVAR(maxWeightCarryRun), "SLIDER",
    [LSTRING(maxWeightCarryRun_displayName), LSTRING(maxWeightCarryRun_description)],
    LSTRING(weight_category),
    [0,500,50,0],
    true
] call CBA_fnc_addSetting;

@Dystopian
Copy link
Contributor Author

  • create stringtable values for 3 names and descriptions and their translating;
  • edit documentation;
  • testing and fixing.

Don't get me wrong, I just don't need all this work. I even think this setting is really useless for anyone and global variable is more than enough. Please feel free to make your PRs for it.

@severgun
Copy link
Contributor

edit documentation

You introduce new magic variable and need to do this as well.

Please feel free to make your PRs for it.

Ok I will.

@10Dozen
Copy link
Contributor

10Dozen commented Jul 27, 2021

Maybe some weight check inside PFH? As i understand it is possible to load more items into carried box/weapon holder by other players, ace_common_fnc_claim only blocks accessing items for drag/carry/disassemble.

@BaerMitUmlaut
Copy link
Member

That's a good point @10Dozen, but I would classify this as a general bug, not a problem specific for this PR. Maybe we should use lockInventory to block inventory access?

@10Dozen
Copy link
Contributor

10Dozen commented Jul 27, 2021

Maybe we should use lockInventory to block inventory access?

TBH when carriable weaponHolders will be added - ability to access carried holder will be pretty useful. E.g. you can pick some AT launcher, scroll up to move it higher and other players (that are sitting on rooftop of a small house) will be able to take it right from your hands.
So maybe InventoryClosed EH with quantity/mass re-calculation and checks?

@LinkIsGrim LinkIsGrim dismissed their stale review June 23, 2023 20:45

Discussed in Discord.

@LinkIsGrim LinkIsGrim merged commit 8b94d76 into acemod:master Jun 28, 2023
@Dystopian Dystopian deleted the dragging-allow-run branch September 11, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants