-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nametags - Add setting to disable effect of ambient brightness on view distance #8325
Conversation
Co-authored-by: jonpas <jonpas33@gmail.com>
We could make this a scalar//"slider" setting
|
How to interpret/name the coefficient? And what range? It is very unclear how slider works |
ambientBrightnessAffectViewDist=1 then it maps 0..1, just like it did before |
I understand how it works in code. I don't know how to describe it in 2 words for regular users. |
Maybe something like: "Controls how strongly ambient brightness affects nametag view distance." |
"Nametag Ambient Brightness Coefficient" "Adjusts how visible nametags are based on the ambient brightness" |
Settings parameter as slider. English and Russian localization.
@PabstMirror Looks good to me. |
Co-authored-by: mharis001 <34453221+mharis001@users.noreply.github.com>
…w distance (acemod#8325) * Add setting to disable effect of ambient brightness on view dist * Add periods and Title Case for English localization * Apply suggested code. Make it more readable Co-authored-by: jonpas <jonpas33@gmail.com> * fix spelling * fix mistype * one more mistype * Implement suggestions Settings parameter as slider. English and Russian localization. * Update addons/nametags/functions/fnc_getCachedFlags.sqf Co-authored-by: mharis001 <34453221+mharis001@users.noreply.github.com> Co-authored-by: jonpas <jonpas33@gmail.com> Co-authored-by: mharis001 <34453221+mharis001@users.noreply.github.com>
When merged this pull request will: