Attach - Improve IR Strobe blinking pattern and increase lifetime #8283
Conversation
Co-authored-by: commy2 <commy-2@gmx.de>
|
Adding different strobes with custom patterns would be neat for IFF |
|
We could provide a couple variants with different patterns. Simplest solution would be to add additional strobe items for each of the patterns but could also allow the user to select the pattern using actions. Not sure how to handle synchronized strobes or how feasible that is. |
|
If we delete all the strobes that are wanted to be synchronized and recreate them all at once, would that do the trick? |
|
Just attach local copies. |
|
What about avoiding creating the strobe until |
| maxLifetime = 8 * 60 * 60; | ||
| blinkingPattern[] = {0.1, 0.9}; // 0.1 s on, 0.9 s off | ||
| blinkingStartsOn = 1; | ||
| blinkingPatternGuarantee = 1; |
There was a problem hiding this comment.
This property doesn't seem to work currently, you get no blinking at all if you use an on time less than a frame's duration (@dedmen?). But it doesn't hurt adding it.
There was a problem hiding this comment.
Dunno, should be same as for that other blinking thing :D
|
We can do additional features like synched blinking later, I would prefer to get this merged for the next release. Unless @mharis001 is already working on that? |
Co-authored-by: BaerMitUmlaut <BaerMitUmlaut@users.noreply.github.com>
|
I briefly experimented with adding strobes with different patterns but that can be done later. Let's get this merged for the next release. |
|
Safe to merge now, but blinking won't take effect til 2.06? |
|
Yes safe to merge now. These config entries will not be used until 2.06. |
) * Improve IR Strobe blinking pattern and increase lifetime * Improve readability of maxLifetime entry Co-authored-by: commy2 <commy-2@gmx.de> * Apply suggestions from code review Co-authored-by: BaerMitUmlaut <BaerMitUmlaut@users.noreply.github.com> Co-authored-by: commy2 <commy-2@gmx.de> Co-authored-by: BaerMitUmlaut <BaerMitUmlaut@users.noreply.github.com>
When merged this pull request will: