-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Medical Treatment - Allow variable CPR chance based on blood volume (invalidates old setting) #7983
Conversation
fbcbb32
to
41adb13
Compare
I like what you're doing here functionally, but I think the settings aren't very transparent. It's fine for anyone like me who can read the code and see that "minimum chance" really means "chance at hemorrhage level 4 and "maximum chance" means at level 1. I think they need to be presented in user terms "CPR success chance with high blood loss" and "with low blood loss" (or whatever in-game corresponding terminology we use). |
Agreed. I'll try to think of a better tooltip, but it's hard to explain interpolation in a concise way. |
41adb13
to
52fa58b
Compare
@mharis001 settings guru, please check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should remove strings for old settings.
Although including the interpolation details may be too technical for setting descriptions, I think it is better to provide as much detail as possible so that the user can completely understand the behaviour from the description instead of leaving them to guess at exactly when the minimum and maximum values are used.
52fa58b
to
8261e15
Compare
8261e15
to
e99dcdc
Compare
When merged this pull request will:
I've left the old stringtable entries in for reference - is this a bad idea?
Interpolates based on blood volume between 60% (below this value you would immediately arrest again) and 85% (minimum threshold for waking up)