-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IR marking laser for aircraft #7761
base: master
Are you sure you want to change the base?
Conversation
more details? I would expect delay by a few frames, and then a "instant" flop into position. |
Perhaps make the laser's dot bigger, to create more of an area marking laser, rather than a pinpoint one? |
Aircraft don't have weapon attachments... |
Here is my script with the hopefully 2.08 scripted lasers feature |
The 3den attribute is weird, it's default value is true. I had to set it to false, which added the attribute to the sqm |
Maybe we should wait for 2.08 and use drawLaser? |
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
How are you testing this? I tried it with the Yabhon drone and a loiter waypoint at 500 m altitude, which seems to work just fine. That was pretty much the use case I had in mind originally. We could switch to the scripted laser later, if that has the same capability (range would be my main concern), but I would prefer not delaying this PR further unless necessary. 2.06 is already taking quite a while, so I don't expect 2.08 to still arrive this year. I've fixed the attribute by enabling the laser by default. The bright spot is odd, since that should be part of the model, which is clearly not visible. I'd assume this is caused by some sort of lazy update within the engine. If you can repro it, please let me know. |
Thats indeed not planned. rather Q1 2022 |
Just a reminder that 2.08 already released. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got loads of
21:49:32 Error in expression <EqualTo [] } do {
_intersects = lineIntersectsSurfaces [_startPos, _endP>
21:49:32 Error position: <lineIntersectsSurfaces [_startPos, _endP>
21:49:32 Error 0 elements provided, 3 expected
21:49:32 File /z/ace/addons/markinglaser/functions/fnc_renderPFH.sqf..., line 357
21:49:32 Error in expression <ivate _elevation = _modelVector#2 atan2 vectorMagnitude [_modelVector # 0, _mode>
21:49:32 Error position: <vectorMagnitude [_modelVector # 0, _mode>
21:49:32 Error Type Any, expected Number
21:49:32 File /z/ace/addons/markinglaser/functions/fnc_renderPFH.sqf..., line 339
being spammed after my plane crashed and I teleported myself out with Zeus (not sure if the teleportation had much of an effect tbh).
Last time I tested this in mp there were big problems with laser position syncing |
* Use laser target * cleanup * Add 3Hz flash mode * spaces * Update script_component.hpp * yeet * update comments * offset laser origin if is source * Update addons/markinglaser/functions/fnc_renderPFH.sqf Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com> * Update addons/markinglaser/XEH_postInit.sqf --------- Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com> Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com> Co-authored-by: Grim <69561145+LinkIsGrim@users.noreply.github.com>
When merged this pull request will:
TODO:
Screenshot:
Reference image (the only one I could find, would love to see more if anybody finds some):
Source
Mainly publishing this as a POC for custom IR lasers, I think the concept is pretty neato.