Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHS Compat - Add Mk17 barrel length config entries #7748

Closed
wants to merge 1 commit into from

Conversation

armyinf0703
Copy link
Contributor

Was missing barrel lengths so the LB version was performing the same as the CQC version. Used FNs website for the barrel lengths.

When merged this pull request will:

  • Describe what this pull request will do
  • Each change in a separate line
  • Include documentation if applicable
  • Respect the Development Guidelines
  • Follow title standard Component - Add|Fix|Improve|Change|Make|Remove bananas

Was missing
@mharis001 mharis001 added area/compatibility kind/enhancement Release Notes: **IMPROVED:** labels Jun 3, 2020
@mharis001 mharis001 added this to the 3.13.3 milestone Jun 3, 2020
@mharis001 mharis001 changed the title Mk17 barrel length added RHS Compat - Add Mk17 barrel length config entries Jun 3, 2020
@Lazejun
Copy link
Contributor

Lazejun commented Jun 3, 2020

#7702 , there are way more than just the Scars

Also this will not set Values for RHSSAFs Black and Tan Scars.

@PabstMirror
Copy link
Contributor

Looks like this was fully handled by #7702

    class rhs_weap_SCAR_H_Base;
    class rhs_weap_SCAR_H_CQC_Base: rhs_weap_SCAR_H_Base {
        ACE_barrelTwist = 304.8; // 1:12"
        ACE_barrelLength = 330.0;
    };
    class rhs_weap_SCAR_H_LB_Base: rhs_weap_SCAR_H_CQC_Base {
        ACE_barrelTwist = 304.8; // 1:12"
        ACE_barrelLength = 508.0;
    };
    class rhs_weap_SCAR_H_STD_Base: rhs_weap_SCAR_H_LB_Base {
        ACE_barrelTwist = 304.8; // 1:12"
        ACE_barrelLength = 406.0;
    };

@PabstMirror PabstMirror modified the milestones: 3.13.3, Ongoing Jun 13, 2020
@PabstMirror
Copy link
Contributor

@LinkIsGrim LinkIsGrim removed this from the Ongoing milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/compatibility kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants