Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hearing - Fix for "MrapAttenuation" #7664

Merged
merged 2 commits into from
May 1, 2020
Merged

Hearing - Fix for "MrapAttenuation" #7664

merged 2 commits into from
May 1, 2020

Conversation

kuloodporny
Copy link
Contributor

Hearing - Fix for "MrapAttenuation"

When merged this pull request will:

  • Make hearing system understand "MrapAttenuation" used in B_MRAP_01_F
  • Prevent players from getting deafened by own HMGs while in MRAPs

Hearing: MRAP Attenuation Fix
@kuloodporny
Copy link
Contributor Author

Hello, this is my first contribution for ACE in Arma 3. Hope it's self explaining enough.

I've noticed that my vehicle's gunners kept getting deaf. It turned out that ACE Hearing did not recognize the attenuation model "MrapAtttenuation" and considered it always open.

Ideally this should be done automatically via analysis of configFile >> CfgSoundEffects >> AttenuationsEffects but I don't understand the exact format of this class so far.

@BaerMitUmlaut BaerMitUmlaut added the kind/bug-fix Release Notes: **FIXED:** label Apr 26, 2020
@PabstMirror
Copy link
Contributor

x = []; 
{ 
    x pushBackUnique getText (_x >> "attenuationEffectType") 
} forEach ("true" configClasses (configFile >> "CfgVehicles"));

["","OpenCarAttenuation","PlaneAttenuation","TankAttenuation","CarAttenuation","TruckAttenuation","SemiOpenCarAttenuation2","MrapAttenuation","OpenHeliAttenuation","HeliAttenuation","SemiOpenHeliAttenuation","SemiOpenCarAttenuation","CUP_Ural_CarAttenuation","CUP_UAZ_CarAttenuation"]

looks like we are also missing SemiOpenCarAttenuation2
yeah, I don't like this switch statement stuff
but there is no inheritance in CfgSoundEffects and I couldn't figure out the format either

@PabstMirror PabstMirror added this to the 3.13.3 milestone Apr 26, 2020
Co-Authored-By: PabstMirror <pabstmirror@gmail.com>
@PabstMirror PabstMirror merged commit e2157ac into acemod:master May 1, 2020
@bux
Copy link
Member

bux commented May 1, 2020

@kuloodporny Thank you for your contribution. 😃

@kuloodporny
Copy link
Contributor Author

You're welcome. I hope that I can be of help more in general :)

@kuloodporny kuloodporny deleted the hearing-mrap-attenuation-fix branch May 3, 2020 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants