-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arsenal - add custom right panel misc items buttons #7596
Conversation
Merge killerkompanie
That's a great idea, however I would like to see the following changes:
I know this would increase complexity, but you would just need to calculate a couple positions. |
it is
because there are 10 static atm i placed it under that misc tab
because of the arsenal system and the defines i build it extra static that everything is defined and has a IDC etc. But yeah i can make it dynamic if this is wished. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't binarize __EVAL, __EVAL is banned
Is there a limit? What if users push too many buttons (I'd call that unlikely to happen so prolly no matter) |
Co-Authored-By: Dedmen Miller <dedmen@users.noreply.github.com>
Yeah only 10 Buttons not more
|
Co-Authored-By: Dedmen Miller <dedmen@users.noreply.github.com>
should read before commenting... |
Co-Authored-By: Dedmen Miller <dedmen@users.noreply.github.com>
I cannot see the Apache License in your changes? Or are you trying to just relicense Apache license content as GPL? I don't think that'll work out well. |
You now that i didnt do that on purpose. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good overall, just need minor fix
Aside from these two, lgtm. |
@veteran29 good spot... the background was set after the icon... is fixed. |
When merged this pull request will:
Infos
[["ACE_bloodIV_500", "ACE_Banana"], "Stuff"] call ace_arsenal_fnc_addRightPanelButton
you can do an extra button thereicon is from https://material.io/Example for medical
With this code, you have a setting for ace_medical to add a custom button with all medical stuff.
If this is good, i can add this also to this PR.
Example/Preview