Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair Overhaul #2861

Merged
merged 3 commits into from
Nov 25, 2015
Merged

Repair Overhaul #2861

merged 3 commits into from
Nov 25, 2015

Conversation

PabstMirror
Copy link
Contributor

ReBased Old PR #2616

Fixes:
#2307 - Repair Sub-turrets (commander's gun)
#2742 - Handle weird wheel configs
#2452 - Fix Body/Fuel Repair location for Hatchback
#2643 - Script error

ACE_isEngineer being scalar
Removed wheels not having damage set
Re-added normalizing "depends" hitpoints

Added:
Claim/Release repair items while repairing

PabstMirror and others added 3 commits November 20, 2015 21:11
Privates

Cleanup debug

Add repair actions for sub turrets

Cleanup

Fix Header

Error Handling

Cleanup setHitpointDamage

Fix common ACE_isEngineer to handle scalar or bool

Claim and release repair objects (wheel/track)

Repair sub-turrets
Only valid hit selection + hit point combinations are usable for repair points:

- Empty hit points mean there isn't enough information to display to the user
- Empty hit selections mean that the hit point doesn't actually exist
Stuff

Normalize Depends - Skip Glass Repair

Fix spawned wheel/track not having correct damage

getHitpointString robustness, hatchback fuelHitpoint, fix count errors

-

Formatting

local -> private

Fix Stuff
@PabstMirror PabstMirror added kind/enhancement Release Notes: **IMPROVED:** kind/bug-fix Release Notes: **FIXED:** labels Nov 21, 2015
@PabstMirror PabstMirror added this to the 3.4.0 milestone Nov 21, 2015
@kymckay
Copy link
Member

kymckay commented Nov 22, 2015

To clarify:

Claim/Release repair items while repairing

Does this refer to only one person being able to use an item (e.g. wheel) on the ground at any given time?

@PabstMirror
Copy link
Contributor Author

Yeah, it's the same system that carrying/dragging uses to prevent interaction with the object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:** kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants