Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Map Light Interactions #2748

Merged
merged 2 commits into from
Oct 17, 2015
Merged

Conversation

PabstMirror
Copy link
Contributor

Currently each flashlight has 2 mutually exclusive child actions
This just shortens the depth of the action tree and puts the toggle action on the flashlight itself.
(The 4th level can be hard to reach on some interface sizes)

@voiperr - If you were planning on adding other actions besides on/off or have any other objections to this please let me know.

before
a

after
bb

@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Oct 14, 2015
@jokoho48
Copy link
Member

what about color switching? didnt have the KSF-1 3 color modes?
else 👍

@voiperr
Copy link
Contributor

voiperr commented Oct 14, 2015

The intent was to eventually give colour modes (and filter switching) to the appropriate flashlights, but this was contingent on eventually getting the flashlights to be equippable as weapons.

This change is fine for now, just keep in mind it will be reverted if we ever implement equippable flashlights.

@PabstMirror
Copy link
Contributor Author

It is possible to add children but have the parent still have a working statement, like this:

image

@voiperr
Copy link
Contributor

voiperr commented Oct 14, 2015

I'm fine with that, but is it consistent with how the rest of ACE's actions work? The parent node never performs functions in Explosives, for instance.

@jokoho48
Copy link
Member

if i am right of cause the microDAGR have a sub action under configure if i am righ

@jonpas
Copy link
Member

jonpas commented Oct 14, 2015

I'm fine with that, but is it consistent with how the rest of ACE's actions work? The parent node never performs functions in Explosives, for instance.

I think I saw plans to change that somewhere.

[[_onAction, [], _player], [_offAction, [], _player]]
_statement = {};

_statement = if (GVAR(flashlightInUse) == _x) then {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will always return something, so the previous _statement = {}; initialization isn't required here.

@thojkooi thojkooi added this to the 3.4.0 milestone Oct 17, 2015
jokoho48 added a commit that referenced this pull request Oct 17, 2015
@jokoho48 jokoho48 merged commit 1365aeb into fixFlashlightPrivates Oct 17, 2015
@jokoho48 jokoho48 deleted the simpleMapLightActions branch October 17, 2015 21:19
@commy2
Copy link
Contributor

commy2 commented Oct 18, 2015

This is excellent. Simplify, simplify, simplify!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants