-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify Map Light Interactions #2748
Conversation
what about color switching? didnt have the KSF-1 3 color modes? |
The intent was to eventually give colour modes (and filter switching) to the appropriate flashlights, but this was contingent on eventually getting the flashlights to be equippable as weapons. This change is fine for now, just keep in mind it will be reverted if we ever implement equippable flashlights. |
I'm fine with that, but is it consistent with how the rest of ACE's actions work? The parent node never performs functions in Explosives, for instance. |
if i am right of cause the microDAGR have a sub action under configure if i am righ |
I think I saw plans to change that somewhere. |
[[_onAction, [], _player], [_offAction, [], _player]] | ||
_statement = {}; | ||
|
||
_statement = if (GVAR(flashlightInUse) == _x) then { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will always return something, so the previous _statement = {};
initialization isn't required here.
Simplify Map Light Interactions
This is excellent. Simplify, simplify, simplify! |
Currently each flashlight has 2 mutually exclusive child actions
This just shortens the depth of the action tree and puts the toggle action on the flashlight itself.
(The 4th level can be hard to reach on some interface sizes)
@voiperr - If you were planning on adding other actions besides on/off or have any other objections to this please let me know.
before
after