Code cleanup / refactoring Goggles #2648
Conversation
|
|
|
||
| if (!isClass _config) exitWith {false}; | ||
|
|
||
| getNumber (_config >> "mode") == 1 // return |
There was a problem hiding this comment.
Out of curiosity, what does the "mode" property represent?
There was a problem hiding this comment.
mode = 1; is a config entry that changes the behaviour of glasses.
Usually glasses are hidden on the unit if it gets into the water even though they are equipped in that slot.
That is reversed when mode is set to 1. The glasses are only shown when in water. This is used for diving goggles in vanilla.
| if (GVAR(showInThirdPerson)) exitWith { false }; | ||
|
|
||
| (cameraView in ["EXTERNAL", "GROUP"] || {call EFUNC(common,isFeatureCameraActive)}) | ||
| cameraView in ["EXTERNAL", "GROUP"] || EFUNC(common,isFeatureCameraActive) // return |
There was a problem hiding this comment.
Ah wait, I see, it's automatically lazy evaluation because the function is code
There was a problem hiding this comment.
The implemenation of lazy evaluation is nothing more than the addition of the alternative syntax of && and || which is BOOL && CODE etc.
|
After some testing it seems that everything still works as expected. Merge? |
Code cleanup / refactoring Goggles
ref: #2144