Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CPR params #2492

Merged
merged 1 commit into from
Sep 17, 2015
Merged

Fix CPR params #2492

merged 1 commit into from
Sep 17, 2015

Conversation

PabstMirror
Copy link
Contributor

@PabstMirror PabstMirror added the kind/bug-fix Release Notes: **FIXED:** label Sep 17, 2015
@commy2
Copy link
Contributor

commy2 commented Sep 17, 2015

param is a ugly trap for everyone using autocomplete with the scripting commands. Noticed that too.

@kymckay kymckay added this to the 3.4.0 milestone Sep 17, 2015
@kymckay
Copy link
Member

kymckay commented Sep 17, 2015

Since this is targeted at master I'd go ahead and merge it, will probably want to hotfix into release too

Scratch that, would want to hotfix into release then merge back into master

PabstMirror added a commit that referenced this pull request Sep 17, 2015
@PabstMirror
Merge pull request #2492 from acemod/fixCPR
7faee2e 
Fix CPR params
@PabstMirror PabstMirror merged commit 7faee2e into master Sep 17, 2015
@PabstMirror PabstMirror deleted the fixCPR branch September 17, 2015 17:37
@kymckay
Copy link
Member

kymckay commented Sep 17, 2015

I have no idea what happened, but that works 😆 👍

Was that a cherry pick?

@PabstMirror
Copy link
Contributor Author

just branched off of release, so merge is easy to both branches

@jokoho48 jokoho48 modified the milestones: 3.3.2, 3.4.0 Sep 19, 2015
@PabstMirror PabstMirror mentioned this pull request Sep 22, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Milestone
3.3.2
Development

Successfully merging this pull request may close these issues.
4 participants
@PabstMirror @commy2 @kymckay @jokoho48