-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed Vignette and Cleaned up UI component #2368
Conversation
Conflicts: addons/ui/README.md addons/ui/config.cpp
Status? |
I'm for merging this. This thing will not be missed. |
@@ -9,3 +9,4 @@ Changes the chat contrast on the map to allow easier reading. | |||
The people responsible for merging changes to this component or answering potential questions. | |||
|
|||
- [VKing](https://github.com/VKing6) | |||
- [Jonpas](https://github.com/jonpas) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately you can't add yourself as a maintainer here 😢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Damn, that is left over from the bigger PR in which I am waiting for new commands that didn't make it into 1.50, I just cherry-picked. :)
👍 In favour |
Good to go! |
@@ -1 +0,0 @@ | |||
#include "\z\ace\addons\ui\script_component.hpp" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this being deleted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see, because there are no functions 👍 Nevermind 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍌
👍 |
Removed Vignette and Cleaned up UI component
Separated from #1857