Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sitting improvements #2338

Merged
merged 2 commits into from
Sep 3, 2015
Merged

Sitting improvements #2338

merged 2 commits into from
Sep 3, 2015

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Sep 1, 2015

No description provided.

@commy2 commy2 added kind/enhancement Release Notes: **IMPROVED:** kind/bug-fix Release Notes: **FIXED:** labels Sep 1, 2015
@commy2 commy2 self-assigned this Sep 1, 2015
@commy2 commy2 added this to the 3.3.0 milestone Sep 1, 2015
@jonpas
Copy link
Member

jonpas commented Sep 1, 2015

Tested it, works very nicely, great work! 👍

With this we no longer need the "restrict movement by GVAR(sitRotation)" in the PFH, I'll remove it once this gets merged and also cleanup some of it.

Another though, is it possible to hide the backpack like in vehicles? I think it would be preferred.

Side question, what does static = 1 do exactly? I can't find any docs of it anywhere.

@@ -1,6 +1,9 @@
// Enable visual head movement while free-looking
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That comment can be removed or new things added.

@commy2
Copy link
Contributor Author

commy2 commented Sep 1, 2015

head = "headDefault"; ... head turns in view direction
aimingBody = "aimingNo"; ... upper body doesn't turn in view direction (also leaning)
forceAim = 1; ... always in freelook mode
static = 1; ... whole body doesn't turn when rotating / can't rotate (rotating != viewing)

@jonpas
Copy link
Member

jonpas commented Sep 1, 2015

Awesome, thanks for the explanations! I was at least on a good path. :)

@commy2
Copy link
Contributor Author

commy2 commented Sep 1, 2015

Feedback on the scroll wheel action? Any time someone wanted to sit for the first time, they were stuck, because they didn't know how to stand up again. This should be way more intuitive. Works with GetOut shortcut (V).

@MikeMatrix
Copy link
Contributor

@commy2 I think that's a good addition. Probably feels a lot more natural with the V shortcut working as well

@MikeMatrix
Copy link
Contributor

@commy2 In that sense, maybe it might be wiser to rename that action to Get out instead, so the user can intuitively make the connection that the V shortcut works on this?

@commy2
Copy link
Contributor Author

commy2 commented Sep 1, 2015

In my social experiment everyone (4 of 4 .. including myself) tried to press V first. The action is only there to enable the hotkey.

@jonpas
Copy link
Member

jonpas commented Sep 1, 2015

I like it! 👍

@alganthe
Copy link
Contributor

alganthe commented Sep 1, 2015

👍

@MikeMatrix
Copy link
Contributor

@commy2 Alright. Although that sample size is not particularly huge :shipit:
We can always change it later if it isn't understood universally.
👍

commy2 added a commit that referenced this pull request Sep 3, 2015
@commy2 commy2 merged commit 529c85d into master Sep 3, 2015
@commy2 commy2 deleted the 322sit branch September 3, 2015 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:** kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants