Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EnableTeamManagement setting for joinGroup #2027

Merged
merged 1 commit into from
Aug 8, 2015
Merged

EnableTeamManagement setting for joinGroup #2027

merged 1 commit into from
Aug 8, 2015

Conversation

PabstMirror
Copy link
Contributor

#2024

I'm pretty sure joinGroup should be disabled if EnableTeamManagement is false.
Unless we want separate settings for fireteam team management (different colors) and a setting for joining/leaving groups.

@PabstMirror PabstMirror added the kind/bug-fix Release Notes: **FIXED:** label Aug 5, 2015
@PabstMirror PabstMirror added this to the 3.3.0 milestone Aug 5, 2015
@thojkooi
Copy link
Contributor

thojkooi commented Aug 8, 2015

I think the same would count for leaveGroup.

@PabstMirror
Copy link
Contributor Author

leaveGroup is a child of ACE_TeamManagement so it has the condition checked there

PabstMirror added a commit that referenced this pull request Aug 8, 2015
@PabstMirror
Merge pull request #2027 from acemod/joinGroupTeamManagement
451c88c 
EnableTeamManagement setting for joinGroup
@PabstMirror PabstMirror merged commit 451c88c into master Aug 8, 2015
@PabstMirror PabstMirror deleted the joinGroupTeamManagement branch August 8, 2015 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@PabstMirror @thojkooi