Fix Server not reading modules #1598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Totally true, and definitely an improvement but... I'm thinking now that if "SettingsInitialized" shouldn't be thrown only after the init from module thing has finished on the server. TBH this whole settings system is giving me headaches atm. |
|
Keep your thoughts on this one. This PR is important for most communities. I'd like to see it get finished in time. |
nicolasbadano
added a commit
that referenced
this pull request
Jun 13, 2015
Fix Server not reading modules
|
I've read it more carefully, and @PabstMirror addressed my concern already. Perfect! Bottom line: 1 - Server inits settings from config Brilliant! That's exactly what we need. Initing features on "SettingsInitialized" should be now much more reliable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Critical:
InitSettingsFromModulesin only called from a PFEH bellowif (!hasInterface) exitWith {};,so dedicated servers never read modules.
Also, fixes a possible issue where the server has synced GVAR(settings), but not finished syncing all the modules. Clients could raise
SettingsInitializedbefore all module setting have been recieved. Server now sets a bool publicVariable after reading all modules.