Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rain each frame #1526

Merged
merged 2 commits into from
Jun 13, 2015
Merged

Update rain each frame #1526

merged 2 commits into from
Jun 13, 2015

Conversation

ulteq
Copy link
Contributor

@ulteq ulteq commented Jun 6, 2015

Prevents interrupted raining.

@ulteq ulteq added kind/bug-fix Release Notes: **FIXED:** status/experimental labels Jun 6, 2015
@ulteq ulteq self-assigned this Jun 6, 2015
@ulteq ulteq added this to the Backlog milestone Jun 6, 2015
@Zoxjib
Copy link
Contributor

Zoxjib commented Jun 6, 2015

This is how Weather behaves when Overcast is set between 0.64 to 0.69 in ACE3.0.1:

https://www.youtube.com/watch?v=j_vwMBHEfr0

This is how Weather behaves when Overcast is set to 85 and Forecasted Overcast is set to 0 in 30 minutes after this particular change:

https://www.youtube.com/watch?v=RemvE5RgP5g

tl;dw: This fix seems good.

-EDIT: The change from rain to no rain is very sudden, is it something that can be fixed or an engine limitation?

Example: https://youtu.be/RemvE5RgP5g?t=12m30s

@ulteq ulteq modified the milestones: 3.1.0, Backlog Jun 13, 2015
nicolasbadano added a commit that referenced this pull request Jun 13, 2015
@nicolasbadano nicolasbadano merged commit 179ad6c into master Jun 13, 2015
@nicolasbadano nicolasbadano deleted the rainExperiment branch June 13, 2015 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants