Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ported the ACE2 Spotting Scope #1515

Merged
merged 3 commits into from
Jun 5, 2015
Merged

Ported the ACE2 Spotting Scope #1515

merged 3 commits into from
Jun 5, 2015

Conversation

ulteq
Copy link
Contributor

@ulteq ulteq commented Jun 5, 2015

@ulteq ulteq added the ACE2 Port label Jun 5, 2015
@ulteq ulteq self-assigned this Jun 5, 2015
@ulteq ulteq added this to the 3.1.0 milestone Jun 5, 2015
@PabstMirror
Copy link
Contributor

Looks great,

Ulteq, I hope it's ok, I just added inheritance on ace_actions and switched the pickup to use EFUNC(common,addToInventory).

I'm just wondering, should the scope have night vision?

@ulteq
Copy link
Contributor Author

ulteq commented Jun 5, 2015

Ulteq, I hope it's ok.

Help is always welcome.

I'm just wondering, should the scope have night vision?

Nope.

@ulteq ulteq changed the title Ported the ACE2 spotting scope Ported the ACE2 Spotting Scope Jun 5, 2015
@nicolasbadano
Copy link
Contributor

👍 Congrats @ulteq for bringing the juicy stuff

ulteq added a commit that referenced this pull request Jun 5, 2015
@ulteq
Merge pull request #1515 from acemod/spotting_scope
c22a66b 
Ported the ACE2 Spotting Scope
@ulteq ulteq merged commit c22a66b into master Jun 5, 2015
@ulteq ulteq deleted the spotting_scope branch June 5, 2015 15:03
@ulteq ulteq mentioned this pull request Jun 14, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ulteq ulteq

Labels
None yet
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ulteq @PabstMirror @nicolasbadano