CheckPBOs in ACE_Settings

[jonpas]

#1123

[thojkooi]

This looks good. I will look at it in more detail later today.

[nicolasbadano]

If the settings command to do so, the pbo checking code should be run after postInit without needing the module.

[jonpas]

I think that requires some restructuring if I understood what you mean (running check version without needed the module placed)?

[nicolasbadano]

Yes. I think it's simply a matter of installing a "SettingsInitialized" even handler that runs the module code if the correct settings are set. That routine and the module should set some flag to avoid checking it twice if the module is present.

[ViperMaul]

@jonpas, @Glowbal
I would really like to see this one completed for 3.1.0 in the next 3 days if possible.

[jonpas]

I will have time to work on it tomorrow or Thursday. I don't particularly get @esteldunedain 's comment though, I have to dive into the code way more. 😁

[jonpas]

@esteldunedain I am actually confused by your statement, SettingsInitialized hasn't been added yet as far as I can see, so what exactly do you want me to do here?

[nicolasbadano]

@esteldunedain I am actually confused by your statement, SettingsInitialized hasn't been added yet as far as I can see, so what exactly do you want me to do here?

It was merged today, so it should be gtg

[jonpas]

Yep yep, will work on it today or tomorrow. Thanks!

[jonpas]

I did what @esteldunedain wanted or at least I think I did. I streamlined module settings loading and then calling the actual function from withing SettingsInitialized, it all works locally it seems but it should probably be tested on dedicated as well, if someone can do that it would be greatly appreciated.

[thojkooi]

This is now always checking pbos, no?

Script looks ok from that I can tell, just need someone to test this on a dedicated server with JIP, like @jonpas said.

[jonpas]

AFAIK it will now always check ACE3 PBOs but only display warnings, if checkPBOsCheckAll is set to true then it will check all.

Is it by default that when no module is present it doesn't check at all? TBH I'd prefer it always checks, it gets rid of a lot of wrong testing setups where players have different ACE3 versions installed.

Code itself has to be cleaned up at some point as well though.

[thojkooi]

Thank you @jonpas

[jonpas]

Thank you!