Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map Tools - Fix Straight Line Drawing being broken by Higher Draw Priority #10635

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mrschick
Copy link
Contributor

@mrschick mrschick commented Jan 9, 2025

When merged this pull request will:

  • Fixes an issue where lines drawn along a map tool would not be straightened if the mission had an editor-placed marker with a draw priority higher than 0.
    As mentioned here, since 2.18 allMapMarkers is ordered according to priority first, instead of creation. That causes those markers with higher priority to always be at the end of the array.
    The current code however still assumes that allMapMarkers select -1 is always the line that was just drawn, causing it to compare the cached GVAR(drawPosStart) with the wrong marker and always aborting line straightening due to the distance check.

@PabstMirror PabstMirror added this to the 3.18.2 milestone Jan 10, 2025
@PabstMirror PabstMirror added the kind/bug-fix Release Notes: **FIXED:** label Jan 10, 2025
@PabstMirror PabstMirror modified the milestones: 3.18.2, Ongoing Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants