Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Medical GUI - Add tooltip in medical menu for holster required setting #10634

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

SpicyBagpipes
Copy link
Contributor

When merged this pull request will:

  • Title

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@@ -26,6 +26,12 @@ params ["_display"];
};
_ctrl ctrlEnable _enable;

if (!_enable && ((EGVAR(medical_treatment,holsterRequired) > 0) && currentWeapon ace_player isNotEqualTo "")) then {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of how I've done this, as it's pretty unyielding - but provides a catch-all that will work for all setting presets even if other options (such as just lowering the weapon) is allowed

@SpicyBagpipes SpicyBagpipes marked this pull request as ready for review January 8, 2025 20:54
@SpicyBagpipes
Copy link
Contributor Author

Found an issue in it removing the previous tooltip, one moment to fix

Tooltips are already handled elsewhere
@SpicyBagpipes
Copy link
Contributor Author

Fixed

@SpicyBagpipes
Copy link
Contributor Author

Now should be all good

Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants