Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RF Compat - Extinguish vehicle cook-offs and burning units #10604

Merged
merged 3 commits into from
Dec 27, 2024
Merged

RF Compat - Extinguish vehicle cook-offs and burning units #10604

merged 3 commits into from
Dec 27, 2024

Conversation

johnb432
Copy link
Contributor

When merged this pull request will:

  • Title.
  • Fire sources created by burning vehicles are already handled.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added the kind/enhancement Release Notes: **IMPROVED:** label Dec 26, 2024
@johnb432 johnb432 added this to the 3.18.2 milestone Dec 26, 2024
LinkIsGrim
LinkIsGrim approved these changes Dec 26, 2024
View reviewed changes
Copy link
Contributor

@LinkIsGrim LinkIsGrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works

addons/fire/XEH_postInit.sqf Outdated Show resolved Hide resolved
@johnb432 johnb432 requested a review from LinkIsGrim December 26, 2024 21:11
@PabstMirror PabstMirror merged commit 3479df8 into master Dec 27, 2024
3 checks passed
@PabstMirror PabstMirror deleted the compat-rf-extinguish-units-and-vehicles branch December 27, 2024 01:07
PlayerBotPro pushed a commit to PlayerBotPro/ACE3 that referenced this pull request Jan 14, 2025
@johnb432 @PlayerBotPro
RF Compat - Extinguish vehicle cook-offs and burning units (acemod#10604
9895be3 
)

* Extinguish cookoffs and burning units

* Introduce new variable to interrupt cook-off

Avoids needing to toggle the enableAmmoCookoff variable

* Moved to RF compat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinkIsGrim LinkIsGrim LinkIsGrim approved these changes

@PabstMirror PabstMirror PabstMirror approved these changes

Assignees
No one assigned
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.19.0
Development

Successfully merging this pull request may close these issues.
3 participants
@johnb432 @PabstMirror @LinkIsGrim