Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explosives - Allow negative dig offsets to always apply #10547

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

johnb432
Copy link
Contributor

When merged this pull request will:

  • Allows negative offset to be applied to non-diggable surfaces (e.g. in the VR world)

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added the kind/change Release Notes: **CHANGED:** label Dec 15, 2024
@johnb432 johnb432 added this to the 3.18.2 milestone Dec 15, 2024
if ((_surfaceType != "") || {isClass (configFile >> "CfgSurfaces" >> _surfaceType >> "soundEnviron")}) then {
private _soundEnviron = getText (configFile >> "CfgSurfaces" >> _surfaceType >> "soundEnviron");
TRACE_2("Dig Down Surface",_surfaceType,_soundEnviron);
_canDigDown = !(_soundEnviron in ["road", "tarmac", "concrete", "concrete_int", "int_concrete", "concrete_ext"]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated to this PR, but I wonder if we should be using common_canDig here instead of hardcoded array?

@LinkIsGrim LinkIsGrim merged commit 7ca1696 into master Dec 16, 2024
3 checks passed
@LinkIsGrim LinkIsGrim deleted the explosives-improve-negative-offset branch December 16, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/change Release Notes: **CHANGED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants