Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interaction - Add "open backpack" action #10525

Merged
merged 19 commits into from
Dec 13, 2024
Merged

Interaction - Add "open backpack" action #10525

merged 19 commits into from
Dec 13, 2024

Conversation

DartRuffian
Copy link
Contributor

When merged this pull request will:

  • Add a new ACE Action to open a unit's backpack

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

johnb432
johnb432 reviewed Nov 26, 2024
View reviewed changes
addons/interaction/functions/fnc_openBackpack.sqf Outdated Show resolved Hide resolved
addons/interaction/functions/fnc_getBackpackPos.sqf Outdated Show resolved Hide resolved
addons/interaction/functions/fnc_canOpenBackpack.sqf Outdated Show resolved Hide resolved
addons/interaction/CfgVehicles.hpp Outdated Show resolved Hide resolved
@LinkIsGrim
Copy link
Contributor

Can't the interaction just be added to the backpack itself?

@DartRuffian
Copy link
Contributor Author

Can't the interaction just be added to the backpack itself?

They don't have extended event handlers. Would require CBA to add them

johnb432
johnb432 previously approved these changes Dec 7, 2024
View reviewed changes
@johnb432 johnb432 added the kind/feature Release Notes: **ADDED:** label Dec 7, 2024
@johnb432 johnb432 added this to the 3.18.2 milestone Dec 7, 2024
@johnb432 johnb432 dismissed their stale review December 8, 2024 08:34

Currently bad params are being passed

@PabstMirror
Copy link
Contributor

in testing the backpack interaction point could sometimes obscure (and hide) the torso interaction point
so we might want a setting for this based on feedback, but I don't think we need it right now

@DartRuffian @PabstMirror
Update addons/interaction/CfgVehicles.hpp
3c060e7 
Co-authored-by: PabstMirror <pabstmirror@gmail.com>
@LinkIsGrim LinkIsGrim merged commit 7aeb6b5 into acemod:master Dec 13, 2024
3 checks passed
@LinkIsGrim LinkIsGrim changed the title Interaction - Add open backpack action Interaction - Add "open backpack" action Dec 20, 2024
@DartRuffian DartRuffian deleted the interaction/open-backpack branch December 28, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rautamiekka rautamiekka rautamiekka left review comments

@johnb432 johnb432 johnb432 approved these changes

@PabstMirror PabstMirror PabstMirror approved these changes

Assignees
No one assigned
Labels
kind/feature Release Notes: **ADDED:**
Projects
None yet
Milestone
3.19.0
Development

Successfully merging this pull request may close these issues.
5 participants
@DartRuffian @LinkIsGrim @PabstMirror @rautamiekka @johnb432