Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General - Sort stringtable entries alphabetically #10475

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

johnb432
Copy link
Contributor

@johnb432 johnb432 commented Nov 3, 2024

When merged this pull request will:

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added the kind/translation Release Notes: **TRANSLATIONS:** label Nov 3, 2024
@johnb432 johnb432 added this to the 3.18.2 milestone Nov 3, 2024
addons/xm157/stringtable.xml Outdated Show resolved Hide resolved
@johnb432
Copy link
Contributor Author

johnb432 commented Nov 5, 2024

I'll rerun the script it when BrettMayson/HEMTT#822, BrettMayson/HEMTT#824 and BrettMayson/HEMTT#825 have been resolved, so don't merge yet.

@johnb432
Copy link
Contributor Author

I reran the script with HEMTT 1.13.5 and compared the output to the output from the script run on current master: they are the identical, so all is good.

@johnb432
Copy link
Contributor Author

I'll take care of merge conflicts in existing PRs.

@johnb432 johnb432 merged commit 654f2e9 into master Nov 12, 2024
3 checks passed
@johnb432 johnb432 deleted the general-stringtable-sort branch November 12, 2024 17:36
@BrettMayson
Copy link
Member

BrettMayson commented Nov 12, 2024

This has no terminating newlines?

If I run with my local HEMTT they all get added

@johnb432
Copy link
Contributor Author

johnb432 commented Nov 12, 2024

I made sure to rerun it after 1.13.5 and no new lines were added at the end of files.

EDIT: nvm, I thought I had updated but I haven't, I'll double check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/translation Release Notes: **TRANSLATIONS:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants