-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Conversation
plz run build https://github.com/acdlite/recompose/blob/master/package.json#L12 and add size-snapshot into the pr |
Fix acdlite#742 using solution from @gaearon (copy/paste)
I had to update yarn.lock as well. I have node 10 installed and upath 1.0.4 is incompatible. I committed them as well because they are involved in the size snapshot. |
Thank you! |
Awesome! |
@oliviertassinari having that pure was commited into react codebase facebook/react#13748 it is the latest days of recompose in material-ui ;-) |
Oh could Andrew do that to it's own project! We are still using |
Time goes fast :-) because of flow issues I didnt use recompose in my own projects more than 6 monthes. (relay also played a role as I almost dont need any data conversions) |
@istarkov recompose is damn useful. Both for authoring HOCs and for consuming them. I love the new to render props helper. |
Will there be a new release soon, I am currently getting an error If I manually patch this commit in my node_modules, everything works fine again. But that's obviously not a long term solution |
@MrLoh Who is importing fbjs? |
I have no idea why this error occurs, but it comes from inside recompose ( |
@istarkov any ETA for a release including that change ? |
Remove shallowEquals import from fbjs and just copy the function #here
Fix #742 using solution from @gaearon (copy/paste)