Skip to content
This repository was archived by the owner on Sep 10, 2022. It is now read-only.

Removed explicit Nothing.displayName in favor of the inferred name #415

Merged
merged 1 commit into from
Jul 3, 2017

Conversation

Andarist
Copy link
Contributor

No description provided.

@istarkov
Copy link
Contributor

break tests src/packages/recompose/tests/renderNothing-test.js

@Andarist Andarist force-pushed the remove-display-name branch from d624990 to 6b88796 Compare June 29, 2017 06:58
@codecov-io
Copy link

Codecov Report

Merging #415 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #415      +/-   ##
==========================================
- Coverage    88.8%   88.77%   -0.03%     
==========================================
  Files          50       50              
  Lines         375      374       -1     
==========================================
- Hits          333      332       -1     
  Misses         42       42
Impacted Files Coverage Δ
src/packages/recompose/renderNothing.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de2db67...6b88796. Read the comment docs.

@Andarist
Copy link
Contributor Author

@istarkov sorry for this one, I had impression that ive ran the tests. Would u like to receive a PR with tests being configured (with husky) as prepush hook?

Ive fixed the failing test.

@istarkov
Copy link
Contributor

Yes support of lint-staged with husky will be cool, have you checked does this work if we compose withProps and renderNothing, will we have the same displayName as it was?

@Andarist
Copy link
Contributor Author

Gonna send husky PR in a minute.

As to testing this one more - even the changed test should be rather removed as its kinda testing JS feature (inferred names) and React internal way of assigning a component's name.

Everything should work just fine with any composition as long as displayName is correctly set up for HOCs - but that has nothing to do with Nothing itself as its just a class component like any other.

@istarkov istarkov merged commit 90e4453 into acdlite:master Jul 3, 2017
@Andarist Andarist deleted the remove-display-name branch July 3, 2017 11:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants