-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui-contract-editor):drag&drop disabled for embeded clauses #250
feat(ui-contract-editor):drag&drop disabled for embeded clauses #250
Conversation
Signed-off-by: User <shevkar.sanket@gmail.com>
@sanketshevkar it looks like Netlify timed out, can you force push your same code to kickstart the Netlify process again? |
Ok, Sure. |
Signed-off-by: User <shevkar.sanket@gmail.com>
Hmm I'm not sure how checking the header length helps here? Could you elaborate? |
The header for an embedded clause is empty, so if the length of the header of a clause is 0, then don't allow the drag and drop icons get displayed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will have to think about a more reliable mechanism to identify embedded clauses, but this works for now.
@dselman I believe your changes broke the PR. |
Working on it! |
Signed-off-by: User shevkar.sanket@gmail.com
Closes #178
Changes
Related Issues
Author Checklist
--signoff
option of git commit.master
fromfork:branchname