Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui-contract-editor):drag&drop disabled for embeded clauses #250

Merged
merged 5 commits into from
Feb 23, 2021
Merged

feat(ui-contract-editor):drag&drop disabled for embeded clauses #250

merged 5 commits into from
Feb 23, 2021

Conversation

sanketshevkar
Copy link
Member

@sanketshevkar sanketshevkar commented Feb 13, 2021

Signed-off-by: User shevkar.sanket@gmail.com

Closes #178

Changes

  • String match with clause header, if header length is 0 then disable the clause ui-icons.
  • padding added to clause wrapper

Related Issues

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to master from fork:branchname
  • Manual accessibility test performed
    • Keyboard-only access, including forms
    • Contrast at least WCAG Level A
    • Appropriate labels, alt text, and instructions

Signed-off-by: User <shevkar.sanket@gmail.com>
@jolanglinais
Copy link
Member

@sanketshevkar it looks like Netlify timed out, can you force push your same code to kickstart the Netlify process again?

@sanketshevkar
Copy link
Member Author

@sanketshevkar it looks like Netlify timed out, can you force push your same code to kickstart the Netlify process again?

Ok, Sure.

Signed-off-by: User <shevkar.sanket@gmail.com>
@jolanglinais
Copy link
Member

Hmm I'm not sure how checking the header length helps here? Could you elaborate?

@sanketshevkar
Copy link
Member Author

Hmm I'm not sure how checking the header length helps here? Could you elaborate?

The header for an embedded clause is empty, so if the length of the header of a clause is 0, then don't allow the drag and drop icons get displayed.

Copy link
Contributor

@dselman dselman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will have to think about a more reliable mechanism to identify embedded clauses, but this works for now.

@jolanglinais
Copy link
Member

@dselman I believe your changes broke the PR.

@dselman
Copy link
Contributor

dselman commented Feb 23, 2021

@dselman I believe your changes broke the PR.

Working on it!

@dselman dselman merged commit 40a2be4 into accordproject:master Feb 23, 2021
@sanketshevkar sanketshevkar deleted the sanketshevkar/178/DandD-embeded-clauses branch March 3, 2021 04:12
@mttrbrts mttrbrts added the Type: Enhancement ✨ Improvement to process or efficiency label Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A11Y 🔓 Accessibility related Package: Contract Editor 💻 Type: Enhancement ✨ Improvement to process or efficiency Type: Feature Request 🛍️ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't let users drag and drop embedded clauses
4 participants