Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui-markdown-editor): center align h1 tags - I146 #237

Merged
merged 1 commit into from
Feb 8, 2021
Merged

feat(ui-markdown-editor): center align h1 tags - I146 #237

merged 1 commit into from
Feb 8, 2021

Conversation

Udbhavbisarya23
Copy link
Contributor

Signed-off-by: Udbhavbisarya23 udbhavbisarya46.ub@gmail.com

Closes #146

Changed Heading and Made changes to font sizes of ui-markdown-editor

Changes

  • Center Aligned the H1 tags
  • Changed font size and line height of h4,h5 and h6tags to 15,14 and 13 px respectively (As it is in PDF)

Screenshots or Video

img

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to master from fork:branchname
  • Manual accessibility test performed
    • Keyboard-only access, including forms
    • Contrast at least WCAG Level A
    • Appropriate labels, alt text, and instructions

@Udbhavbisarya23
feat(ui-markdown-editor): center align h1 tags - Issue146
9f27144 
Signed-off-by: Udbhavbisarya23 <udbhavbisarya46.ub@gmail.com>
@dselman dselman self-requested a review February 8, 2021 19:12
dselman
dselman approved these changes Feb 8, 2021
View reviewed changes
Copy link
Contributor

@dselman dselman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@jolanglinais jolanglinais changed the title feat(ui-markdown-editor): center align h1 tags - Issue146 feat(ui-markdown-editor): center align h1 tags - I146 Feb 8, 2021
jolanglinais
jolanglinais approved these changes Feb 8, 2021
View reviewed changes
Copy link
Member

@jolanglinais jolanglinais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏻

@jolanglinais jolanglinais merged commit b429ee8 into accordproject:master Feb 8, 2021
@Udbhavbisarya23 Udbhavbisarya23 deleted the Udbhavbisarya23/146/styling-headers branch February 9, 2021 03:38
@Udbhavbisarya23
Copy link
Contributor Author

Thank you @irmerk and @dselman !

@mttrbrts mttrbrts added the Type: Enhancement ✨ Improvement to process or efficiency label Mar 10, 2021
@mttrbrts mttrbrts mentioned this pull request Mar 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jolanglinais jolanglinais jolanglinais approved these changes

@dselman dselman dselman approved these changes

Assignees

@Udbhavbisarya23 Udbhavbisarya23

Labels
Difficulty: Starter Package: Markdown Editor ⌨️ Type: Enhancement ✨ Improvement to process or efficiency Type: Feature Request 🛍️ New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WYSIWYG between Slate and PDF
4 participants
@Udbhavbisarya23 @dselman @jolanglinais @mttrbrts