Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(formula): updates and fixes #180

Merged
merged 3 commits into from
Aug 26, 2020
Merged

feat(formula): updates and fixes #180

merged 3 commits into from
Aug 26, 2020

Conversation

DianaLease
Copy link
Member

@DianaLease DianaLease commented Aug 26, 2020 •
edited
Loading

Closes #

Changes

  • refactor(Formula): refactor code and fix so that dependencies are not hardcoded
  • fix(formula): fix hovering style so it does not overlap actual formula and shows pointer triangle
  • fix(formula): fixes issue where clicking formula multiple times in safari causes crash
  • feat(formula): change style to have different font color with no border

@DianaLease DianaLease self-assigned this Aug 26, 2020
@Michael-Grover
Copy link

Please remove purple border and white background around formula and change formula text color to #AE00BE. This it to make it more clear that formulae can not be directly edited like variables can.

image

@DianaLease
refactor(Formula): refactor and fix so that dependencies are not hard…
9830ed4 
…coded

Signed-off-by: Diana Lease <dianarlease@gmail.com>
@DianaLease
fix(formula): fix hovering style
301e85e 
Signed-off-by: Diana Lease <dianarlease@gmail.com>
@DianaLease
feat(formula): change style to have different font color with no border
140b2c9 
Signed-off-by: Diana Lease <dianarlease@gmail.com>
jolanglinais
jolanglinais approved these changes Aug 26, 2020
View reviewed changes
Copy link
Member

@jolanglinais jolanglinais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 👏 but I'm going to miss the foruma

jeromesimeon
jeromesimeon approved these changes Aug 26, 2020
View reviewed changes
Copy link
Member

@jeromesimeon jeromesimeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

packages/ui-contract-editor/src/lib/ContractEditor/index.js Show resolved Hide resolved
@DianaLease
Copy link
Member Author

@Michael-Grover This has been updated to remove the border and change the font color for formulas

@DianaLease DianaLease merged commit 028ce9b into master Aug 26, 2020
@DianaLease DianaLease deleted the dl-formula-updates branch August 26, 2020 19:41
@DianaLease DianaLease mentioned this pull request Aug 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromesimeon jeromesimeon jeromesimeon approved these changes

@jolanglinais jolanglinais jolanglinais approved these changes

@dselman dselman Awaiting requested review from dselman

@Michael-Grover Michael-Grover Awaiting requested review from Michael-Grover

Assignees

@DianaLease DianaLease

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DianaLease @Michael-Grover @jeromesimeon @jolanglinais