Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui-contract-editor): link updates for variables in a clause, update deps #170

Merged
merged 2 commits into from
Aug 18, 2020
Merged

feat(ui-contract-editor): link updates for variables in a clause, update deps #170

merged 2 commits into from
Aug 18, 2020

Conversation

dselman
Copy link
Contributor

@dselman dselman commented Aug 18, 2020 •
edited
Loading

Signed-off-by: Dan Selman danscode@selman.org

When variables are modified within a clause all occurrences of the variable are automatically updated.

Changes

  • Auto update all occurrences of variables in the onChange handler for withClauses
  • Update Slate to 0.58.4

Flags

  • @jeromesimeon is working on a parser fix that incorrectly names some variables

Screenshots or Video

https://www.loom.com/share/ddace3c9d374415b936284983699fc0a

@dselman
feat(ui-contract-editor): link updates for variables in a clause, upd…
d3b5482 
…ate deps

Signed-off-by: Dan Selman <danscode@selman.org>
@dselman dselman requested a review from DianaLease August 18, 2020 16:07
DianaLease
DianaLease approved these changes Aug 18, 2020
View reviewed changes
Copy link
Member

@DianaLease DianaLease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I would just remove the commented out console.logs before merging.

@dselman
chore(ui-contract-editor): remove console.log
7a9996d 
Signed-off-by: Dan Selman <danscode@selman.org>
@dselman dselman merged commit 991b942 into master Aug 18, 2020
@dselman dselman deleted the ds-link-vars branch August 18, 2020 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DianaLease DianaLease DianaLease approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dselman @DianaLease