fix(ToolbarMethods) Selecting list/quote option while link popup is open crashes demo - #266 #268
Conversation
|
@shrey-sachdeva2000 weren't you working on this ? |
It looked like he just raised this issue, so I thought to work on it. Even if he started, I'm sorry about that. I think we can work together to find a fix for this. |
No worries, please go ahead if you've found a fix! |
|
You've carried over commits from the branch in the PR here: #267 |
|
@irmerk, My bad. I've removed the unnecessary commits, Please have a look at it now! |
|
Nice! It looks like this solves it except for the block quote button. |
Nevermind, I misunderstood the issue. It does not work for the block quote button |
|
@irmerk @DianaLease, My bad. I forgot about block quotes, Please check it now, I have added the fix for block quotes as well. |
|
@Michael-Grover do you mind also having a go at testing this? @98lenvi could you clean up all the commits to be in the format we use in the DEVELOPERS guide and also remove |
|
@irmerk, really sorry about the commit messages, will fix it as soon as possible! |
|
@irmerk, I've made the changes, Please check it whenever you are free. |
| @@ -194,9 +194,11 @@ export const transformListToBlockQuote = (editor, type, value) => { | |||
| */ | |||
| /* eslint no-unused-expressions: 0 */ | |||
| export const transformPtoBQSwap = (editor, type) => { | |||
| isSelectionInput(editor.value, CONST.BLOCK_QUOTE) | |||
| console.log('hi') | |||
There was a problem hiding this comment.
Get rid of this little guy.
There was a problem hiding this comment.
The little guy is gone, Please check it now!
looks like it works to me |
Signed-off-by: lenvi <lenvin@oykuapp.com>
…266 Signed-off-by: lenvi <lenvin@oykuapp.com>
|
@DianaLease, Please check it now, I've added the bugfix at a common place. |
|
This looks geat @98lenvi! This is a bit unusual, but we're implementing a I posted more information about this in slack and will be updating the |
|
Please refer to #298 |
Issue #266
Now the web app doesn't crash when list options are selected when the link popover is open
Changes
ToolbarMethods.jstransformParagraphToListmethod, I have added one more condition check, ie of the text selection is only a link, The behavior of the popover is that it only opens when the selection is only a link.Flags
Related Issues