Skip to content
This repository has been archived by the owner on May 19, 2020. It is now read-only.

fix(MyReactFormVisitor): Make Radio button sample generic #42

Merged
merged 1 commit into from
Feb 24, 2020
Merged

fix(MyReactFormVisitor): Make Radio button sample generic #42

merged 1 commit into from
Feb 24, 2020

Conversation

mttrbrts
Copy link
Member

Issue #40

Fixes #40

@mttrbrts
fix(MyReactFormVisitor): Make Radio button sample generic
4281cfb 
Signed-off-by: Matt Roberts <code@rbrts.uk>
@mttrbrts mttrbrts added the bug Something isn't working label Feb 24, 2020
jeromesimeon
jeromesimeon approved these changes Feb 24, 2020
View reviewed changes
Copy link
Member

@jeromesimeon jeromesimeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeromesimeon
Copy link
Member

Will / should some of that code be in the concerto-ui-core package? Or is having that part of the user code a better option?

@mttrbrts
Copy link
Member Author

Will / should some of that code be in the concerto-ui-core package? Or is having that part of the user code a better option?

I don't think so, MyReactFormVisitor is designed to demonstrate how a user can extend the built-in ReactFormVisitor with custom rendering code. I also think that the default rendering for Enums to Dropdowns is the right default option.

@mttrbrts mttrbrts merged commit cb29801 into master Feb 24, 2020
@mttrbrts mttrbrts deleted the mr-fix-40 branch February 24, 2020 18:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeromesimeon jeromesimeon jeromesimeon approved these changes

@dselman dselman Awaiting requested review from dselman

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enum radio buttons do not update
2 participants
@mttrbrts @jeromesimeon