This repository has been archived by the owner on May 19, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 45
feat(Storybook): extend storybook for developer focused demo - #315 #382
Merged
jolanglinais
merged 14 commits into
accordproject:master
from
98lenvi:98lenvi/i315/dev-focused-demo
Apr 17, 2020
Merged
Changes from 12 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
f86cf62
feat(storybook): Add webpack config - i315
98lenvi f08ec5c
feat(storybook): Add demo file to ContractEditor story - i315
98lenvi 64c5e34
feat(storybook): Add TemplateLibrary story - i315
98lenvi e6a7f2e
feat(storybook): Add Navigation story - i315
98lenvi 7a283f6
feat(storybook): Add ErrorLogger story - i315
98lenvi 6e13998
feat(storybook): Add ContractEditor story - i315
98lenvi d46734e
feat(storybook): Add Demo story - i315
98lenvi 9b86c59
refactor(package.json): move storybook & related dep. to dev-dep - i376
98lenvi 6139ff0
fix(storybook): Change title to 'Cicero UI Components Demo' - i315
98lenvi ec08792
refactor(demo): Revert changes done in f08ec5c0dda94393d63bd50bb31979…
98lenvi 2f4e3ad
feat(*): add netlify.toml to show storybook build in netlify - i315
98lenvi 9fa29bd
fix(storybook): Fix webpack_config that caused issue with production …
98lenvi 2aaf1f3
refactor(storybook): use docs provided with component - i315
98lenvi 437288b
fix(storybook): add knobs for props of ContractEditor - i315
98lenvi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,24 @@ | ||
module.exports = { | ||
stories: ["../src/**/*.stories.[tj]s"], | ||
addons: [ | ||
// '@storybook/addon-actions', | ||
'@storybook/addon-knobs/register', | ||
'@storybook/addon-notes/register', | ||
'@storybook/addon-a11y/register', | ||
// '@storybook/addon-storyshots' | ||
] | ||
}; | ||
const path = require("path"); | ||
const webpack = require("webpack"); | ||
|
||
module.exports = module.exports = { | ||
webpackFinal: async (config, { configType }) => { | ||
config.module.rules.push({ | ||
test: /\.scss$/, | ||
use: ["style-loader", "css-loader", "sass-loader"], | ||
include: path.resolve(__dirname, "../") | ||
}); | ||
config.plugins.push(new webpack.IgnorePlugin(/jsdom$/)); | ||
config = { ...config, node: { fs: "empty", net: "empty", tls: "empty" } }; | ||
// Return the altered config | ||
return config; | ||
}, | ||
stories: ["../src/**/*.stories.[tj]s"], | ||
addons: [ | ||
// '@storybook/addon-actions', | ||
"@storybook/addon-knobs/register", | ||
"@storybook/addon-notes/register", | ||
"@storybook/addon-a11y/register" | ||
// '@storybook/addon-storyshots' | ||
] | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
# Settings in the [build] context are global and are applied to all contexts | ||
# unless otherwise overridden by more specific contexts. | ||
[build] | ||
# Directory to change to before starting a build. | ||
# This is where we will look for package.json/.nvmrc/etc. | ||
base = "/" | ||
|
||
# Directory (relative to root of your repo) that contains the deploy-ready | ||
# HTML files and assets generated by the build. If a base directory has | ||
# been specified, include it in the publish directory path. | ||
publish = "storybook-static/" | ||
|
||
# Default build command. | ||
command = "echo 'default context'" | ||
|
||
# Production context: all deploys from the Production branch set in your site's | ||
# deploy contexts will inherit these settings. | ||
[context.production] | ||
publish = "storybook-static/" | ||
command = "npm run storybook:build" | ||
|
||
# Deploy Preview context: all deploys generated from a pull/merge request will | ||
# inherit these settings. | ||
[context.deploy-preview] | ||
publish = "storybook-static/" | ||
command = "npm run storybook:build" | ||
|
||
# Branch Deploy context: all deploys that are not from a pull/merge request or | ||
# from the Production branch will inherit these settings. | ||
[context.branch-deploy] | ||
command = "echo branch" | ||
[context.branch-deploy.environment] | ||
NODE_ENV = "development" | ||
|
||
# Redirects and headers are GLOBAL for all builds – they do not get scoped to | ||
# contexts no matter where you define them in the file. | ||
# For context-specific rules, use _headers or _redirects files, which are | ||
# PER-DEPLOY. | ||
|
||
# A basic redirect rule | ||
[[redirects]] | ||
from = "/*" | ||
to = "/" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a netlify configuration? We don't do that on any of our projects -- should it be instead done within netlify itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it can be done in Netlify instead.