This repository has been archived by the owner on May 19, 2020. It is now read-only.
feat(*): add storybook for developer focused demo - I315 #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sanyam Dogra <sdlord07@gmail.com>
Signed-off-by: Sanyam Dogra <sdlord07@gmail.com>
|
This is done with @elit-altum as far as I understand. |
Can you clarify this? Who wrote the code, and who signed the DCO? |
|
@jeromesimeon see the work in #335 |
mttrbrts
approved these changes
Mar 20, 2020
jolanglinais
pushed a commit
that referenced
this pull request
Apr 10, 2020
* feat(*): Adds Storybook deps and inital configs - I315 Signed-off-by: Sanyam Dogra <sdlord07@gmail.com> * feat(*): Adds Dummy stories for ContractEditor and ErrorLogger - I315 Signed-off-by: Sanyam Dogra <sdlord07@gmail.com>
jolanglinais
pushed a commit
to jolanglinais/cicero-ui
that referenced
this pull request
Apr 10, 2020
…ct#353) * feat(*): Adds Storybook deps and inital configs - I315 Signed-off-by: Sanyam Dogra <sdlord07@gmail.com> * feat(*): Adds Dummy stories for ContractEditor and ErrorLogger - I315 Signed-off-by: Sanyam Dogra <sdlord07@gmail.com> Signed-off-by: irmerk <jolenelanglinais@gmail.com>
jolanglinais
pushed a commit
that referenced
this pull request
Apr 10, 2020
* feat(*): Adds Storybook deps and inital configs - I315 Signed-off-by: Sanyam Dogra <sdlord07@gmail.com> * feat(*): Adds Dummy stories for ContractEditor and ErrorLogger - I315 Signed-off-by: Sanyam Dogra <sdlord07@gmail.com> Signed-off-by: irmerk <jolenelanglinais@gmail.com>
jolanglinais
pushed a commit
to jolanglinais/cicero-ui
that referenced
this pull request
Apr 10, 2020
…ct#353) * feat(*): Adds Storybook deps and inital configs - I315 Signed-off-by: Sanyam Dogra <sdlord07@gmail.com> * feat(*): Adds Dummy stories for ContractEditor and ErrorLogger - I315 Signed-off-by: Sanyam Dogra <sdlord07@gmail.com>
|
@sanyamdogra can you check to ensure these changes are still in |
jolanglinais
pushed a commit
that referenced
this pull request
Apr 10, 2020
* feat(*): Adds Storybook deps and inital configs - I315 Signed-off-by: Sanyam Dogra <sdlord07@gmail.com> * feat(*): Adds Dummy stories for ContractEditor and ErrorLogger - I315 Signed-off-by: Sanyam Dogra <sdlord07@gmail.com>
|
Hi @irmerk, Yes they have been added to the |
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #315
Changes
@storybook/reactas a dependency.npm run storybook.src/storiesfolder with extension.stories.jsFlags
Related Issues
Screenshots