Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return user to settings page after changing settings (resolves #2272) #2345

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

jobara
Copy link
Collaborator

@jobara jobara commented Nov 4, 2024

Prerequisites

Resolves #2272

  • Updates settings redirects to the top level settings page instead of back to the same page.
    • some pages don't redirect to the top level settings page, for example changes to user account (e.g. password) and roles and permissions.

If this PR changes PHP code or dependencies:

  • I've run composer format and fixed any code formatting issues.
  • I've run composer analyze and addressed any static analysis issues.
  • I've run php artisan test and ensured that all tests pass.
  • I've run composer localize to update localization source files and committed any changes.

If this PR changes CSS or JavaScript code or dependencies:

  • I've run npm run lint and fixed any linting issues.
  • I've run npm run build and ensured that CSS and JavaScript assets can be compiled.

@jobara jobara added this to the 1.5.0 milestone Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.35%. Comparing base (3f4256c) to head (a6c982f).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #2345   +/-   ##
=========================================
  Coverage     97.35%   97.35%           
  Complexity     2188     2188           
=========================================
  Files           338      338           
  Lines         10243    10243           
=========================================
  Hits           9972     9972           
  Misses          271      271           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jobara jobara merged commit 603f981 into accessibility-exchange:dev Nov 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

After changing a setting, the user should be returned to the settings page
1 participant