ci(deploy): add command & queue to put site into maintenance and brin… #1981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g back up after delay
1 task
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #1981 +/- ##
============================================
- Coverage 96.39% 96.31% -0.09%
- Complexity 2070 2073 +3
============================================
Files 312 314 +2
Lines 9023 9031 +8
============================================
Hits 8698 8698
- Misses 325 333 +8 ☔ View full report in Codecov by Sentry. |
jobara
reviewed
Nov 20, 2023
Comment on lines
+32
to
+33
| // Schedule bringing the site back up after 5 minutes | ||
| BringSiteBackUp::dispatch()->delay(now()->addMinutes(5)); |
There was a problem hiding this comment.
I know you mentioned in your comment on the ticket that lifecycle hooks aren't possible at the moment in your infrastructure. I'm just wondering if there really isn't a way to know when the old pod is removed and to trigger the artisan up call then. Unfortunately adding a delay doesn't adequately address the issue.
There was a problem hiding this comment.
We weren't able to come up with an alternative.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a method to put the site into maintenance mode during delpoyments and creates a delayed queue that will bring the site back up within a certain amount of time (5 minutes).
maintenance:queuethat initiates putting the site into maintenance mode and initiating the delayed queue.maintenance:queueat the start of the entrypoint.QUEUE_CONNECTIONfrom sync to redis this allows for delayed queues to occur.