Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: appsettings.json - boolean data type inconsistencies #17830

Closed
leonkosak opened this issue Oct 10, 2023 · 1 comment · Fixed by #17832
Closed

Enhancement: appsettings.json - boolean data type inconsistencies #17830

leonkosak opened this issue Oct 10, 2023 · 1 comment · Fixed by #17832
Assignees
@maliming
Milestone
8.0-preview

Comments

@leonkosak
Copy link
Contributor

Go through all appsettings.json files (open-source and Commercial) and you can see that boolean properties hold value as they should (true/false) and sometimes as string (e.g. "false" - for instance for AuthServer:RequireHttpsMetadata).

What do you think @maliming?
@hikalkan hikalkan added this to the 8.0-preview milestone Oct 10, 2023
@leonkosak
Copy link
Contributor Author

Thank you @hikalkan and @maliming for adding this in 8.0-preview milestone.
Please also check if there are numbers as strings inside all appsettings.json.

maliming added a commit that referenced this issue Oct 10, 2023
@maliming
Use ture/false in appsettings.json.
a0e8d72 
Resolve #17830
@maliming maliming mentioned this issue Oct 10, 2023
Merged
@leonkosak leonkosak mentioned this issue Oct 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maliming maliming

Labels
None yet
Projects
None yet
Milestone
8.0-preview
Development

Successfully merging a pull request may close this issue.

Use true/false in appsettings.json. abpframework/abp
3 participants
@hikalkan @maliming @leonkosak