Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1410 - Added liferay advisories #1774

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Dedsec0098
Copy link

Fix #1410 Added liferay advisories and also imported in the the init.py file

…ES.rst and __init__.py Signed-off-by: Shrish Mishra <shrish409@gmail.com>

Signed-off-by: Shrish0098 <shrish409@gmail.com>
…h409@gmail.com>

Signed-off-by: Shrish0098 <shrish409@gmail.com>
…@gmail.com>

Signed-off-by: Shrish0098 <shrish409@gmail.com>
@Dedsec0098
Copy link
Author

@pombredanne I have added the liferay advisories, please review it and let me know if any further changes are required.

@Rishi-source
Copy link

Hi @Dedsec0098 , I Would like to suggest you some changes which can make you liferay importer even more reliable as well as functional. Please feel free to correct me if I am wrong somewhere :)

Some contributing advices

  • Please make your pull request particular as per you pull request title I can see that you have added NVD Anchor pipeline as well in the same PR in which you have added liferay pipeline.
  • Please Add a Signed off by in your PR description and for more information please consider to read Contributing Guidelines.
    OPTIONAL - If possible then consider making the tests for your pipeline which can run and check the workingness of the code when workflows are applied.

@Dedsec0098
Copy link
Author

Dedsec0098 commented Feb 8, 2025

Hey @Rishi-source Thanks a lot for letting me know!!
Actually I have raise a different PR for NVD Anchore Pipeline and that one is also under review altho I have made a separate branch for both the PRs but due to unmerged PR those changed files are also shown here.

@Rishi-source
Copy link

Do not worry about your unmerged PR while making a new PRs if both the pull req. have unrelated changes (changes which are not conflicting) then github will provide a update branch option whenever new changes are merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Liferay advisories
2 participants