Fillup missing vulnerabilities summary #1767
Open
+225
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
9557b88 to
f4140cd
Compare
pombredanne
requested changes
Feb 11, 2025
| created_by="nvd_importer", summary__isnull=False | ||
| ).exclude(summary="") | ||
| self.log( | ||
| f"Found {nvd_importer_advisories.count()} advisories from NVD importer", |
There was a problem hiding this comment.
Suggested change
| f"Found {nvd_importer_advisories.count()} advisories from NVD importer", | |
| f"Found {nvd_importer_advisories.count()} advisories with summaries from NVD importer", |
| matching_advisories = nvd_importer_advisories.filter(Q(aliases__contains=alias)) | ||
|
|
||
| if matching_advisories.exists(): | ||
| # Take the first matching advisory with a summary |
There was a problem hiding this comment.
Suggested change
| # Take the first matching advisory with a summary | |
| # Take the first matching advisory with a summary. | |
| # NVD advisories only have one alias, always a CVE |
| if matching_advisories.exists(): | ||
| # Take the first matching advisory with a summary | ||
| best_advisory = matching_advisories.first() | ||
| vulnerability.summary = best_advisory.summary |
There was a problem hiding this comment.
Suggested change
| vulnerability.summary = best_advisory.summary | |
| # Note: we filtered above to only get non-empty summaries | |
| vulnerability.summary = best_advisory.summary |
|
|
||
| if matching_advisories.exists(): | ||
| # Take the first matching advisory with a summary | ||
| best_advisory = matching_advisories.first() |
There was a problem hiding this comment.
We should take the latest NVD advisory with the most up-to-date summary, and not the oldest
keshav-space
requested changes
Feb 11, 2025
| level=logging.INFO, | ||
| ) | ||
|
|
||
| for vulnerability in vulnerabilities_qs.paginated(): |
There was a problem hiding this comment.
We should use LoopProgress here
Suggested change
| for vulnerability in vulnerabilities_qs.paginated(): | |
| progress = LoopProgress(total_iterations=vulnerabilities_qs.count(), logger=self.log) | |
| for vulnerability in progress.iter(vulnerabilities_qs.paginated()): |
| for vulnerability in vulnerabilities_qs.paginated(): | ||
| aliases = vulnerability.aliases.values_list("alias", flat=True) | ||
| # get alias that start with CVE- with filter | ||
| alias = aliases.filter(alias__startswith="CVE-").first() |
There was a problem hiding this comment.
We are prefetching aliases with vulnerabilities_qs = Vulnerability.objects.filter(summary="").prefetch_related("aliases"), but that will be rendered useless since this will trigger fresh database query.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #859