-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nuget string representation #64
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM... with just a tiny nit as I prefer to keep one import per line.
Please apply and merge!
tests/test_version_range.py
Outdated
@@ -8,14 +8,14 @@ | |||
import pytest | |||
|
|||
from univers.version_constraint import VersionConstraint | |||
from univers.version_range import GemVersionRange | |||
from univers.version_range import GemVersionRange, NugetVersionRange |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from univers.version_range import GemVersionRange, NugetVersionRange | |
from univers.version_range import GemVersionRange | |
from univers.version_range import NugetVersionRange |
tests/test_version_range.py
Outdated
from univers.version_range import InvalidVersionRange | ||
from univers.version_range import PypiVersionRange | ||
from univers.version_range import VersionRange | ||
from univers.version_range import RANGE_CLASS_BY_SCHEMES | ||
from univers.version_range import NpmVersionRange | ||
from univers.version_range import OpensslVersionRange | ||
from univers.versions import PypiVersion | ||
from univers.versions import NugetVersion, PypiVersion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from univers.versions import NugetVersion, PypiVersion | |
from univers.versions import NugetVersion | |
from univers.versions import PypiVersion |
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Add docs option in configure
Signed-off-by: Tushar Goel tushar.goel.dav@gmail.com