Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NpmVersionRange.from_native not working #79

Closed
ziadhany opened this issue Aug 1, 2022 · 0 comments
Closed

NpmVersionRange.from_native not working #79

ziadhany opened this issue Aug 1, 2022 · 0 comments

Comments

@ziadhany
Copy link
Contributor

ziadhany commented Aug 1, 2022

>>> from univers.version_range import NpmVersionRange
>>> NpmVersionRange.from_native(">=6.1.3")
Traceback (most recent call last):
  File "/home/ziad/Desktop/open_source/vulnerablecode/venv/lib/python3.7/site-packages/IPython/core/interactiveshell.py", line 3553, in run_code
    exec(code_obj, self.user_global_ns, self.user_ns)
  File "<ipython-input-6-7be7de982c98>", line 1, in <module>
    NpmVersionRange.from_native(">=6.1.3")
  File "/home/ziad/Desktop/open_source/vulnerablecode/venv/lib/python3.7/site-packages/univers/version_range.py", line 251, in from_native
    assert isinstance(clause, (AnyOf, AllOf))
AssertionError
TG1999 added a commit to TG1999/univers that referenced this issue Aug 26, 2022
Reference: aboutcode-org#79
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
TG1999 added a commit that referenced this issue Sep 12, 2022
* Fix Npm version range #79

Reference: #79
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>

* Support - in npm version ranges #83

Reference: #83
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>

* Address review comments

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>

* Use named arguments

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>

* Remove space from split

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@ziadhany ziadhany closed this as completed Oct 1, 2022
keshav-space pushed a commit that referenced this issue Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant