Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Product Compare to allow user to save the results #7

Closed
DennisClark opened this issue Dec 7, 2023 · 5 comments
Closed

Enhance Product Compare to allow user to save the results #7

DennisClark opened this issue Dec 7, 2023 · 5 comments
Labels
design needed Design details needed to complete the issue enhancement New feature or request help wanted Extra attention is needed

Comments

@DennisClark
Copy link
Member

The results of a DejaCode Product Compare can be very useful in the ongoing analysis and communication activities that happen during product SCA or the defining of a new product version.

It would be extremely helpful for the User to be able to save the results in Excel format. Other nice formats would be a Word document (where the results would be in a Word document table, if possible) and/or html and/or pdf. But the most important and useful output format would probably be Excel, in order to support analysis, editing, and annotation among product stakeholders.

Note that there are some non-editable workarounds:

  • You can do a browser "Save Page As..." on the Product Comparison, and select "Web Page Complete" (or equivalent, depending on browser), which generates an html file, but with some formatting issues.
  • You can Print the Product Comparison using your browser, perhaps using the save-to-PDF option.
@DennisClark DennisClark added enhancement New feature or request help wanted Extra attention is needed design needed Design details needed to complete the issue labels Dec 7, 2023
@DennisClark DennisClark added this to the DejaCode Future milestone Dec 7, 2023
tdruez added a commit that referenced this issue Feb 15, 2024
Signed-off-by: tdruez <tdruez@nexb.com>
@DennisClark
Copy link
Member Author

DennisClark commented Feb 15, 2024

@tdruez The download works nicely on staging starship. I have one little suggested improvement: perhaps the exported filename should contain the Product Name, since we are normally comparing two versions of the same Product. For example, something like "CargoManager_product_comparison.xlsx" .

@DennisClark
Copy link
Member Author

DennisClark commented Feb 15, 2024

Product Review
If you select two versions of the same Product in the Product list, or two different Products, and click the Compare button, you can now download the results of the comparison to a .xlsx file, making it easy to share the information with your colleagues.

@tdruez
Copy link
Contributor

tdruez commented Feb 15, 2024

I have one little suggested improvement: perhaps the exported filename should contain the Product Name

@DennisClark Since there are 2 products in the comparison, which one should be used in the output file name?

@DennisClark
Copy link
Member Author

DennisClark commented Feb 15, 2024

Ah, never mind about the output file name. I have never compared two different products, just different product versions, but since we support any comparison (I just now tried it), trying to generate a predictable output file name is probably way too complicated. In short, it's great the way it is now, thanks. Suggested release note updated.

tdruez added a commit that referenced this issue Feb 16, 2024
Signed-off-by: tdruez <tdruez@nexb.com>
tdruez added a commit that referenced this issue Feb 16, 2024
* Download Product comparison as XLSX #7

Signed-off-by: tdruez <tdruez@nexb.com>

* Refine code and add unit test #7

Signed-off-by: tdruez <tdruez@nexb.com>

---------

Signed-off-by: tdruez <tdruez@nexb.com>
@tdruez
Copy link
Contributor

tdruez commented Feb 16, 2024

Merged and deployed.

@tdruez tdruez closed this as completed Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design needed Design details needed to complete the issue enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants