Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to replace previous Package/Component version in "Add to Product" #12

Closed
tdruez opened this issue Dec 8, 2023 · 5 comments
Closed
Assignees
Milestone

Comments

@tdruez
Copy link
Contributor

tdruez commented Dec 8, 2023

When adding a package to a product after upgrading the version in the codebase:

  • I'm adding this package to DejaCode
  • Get the automated scan results and generate an ABOUT file that I place along the dist package in the codebase
  • Use "Add to Product" to assign this package to my current product/version
  • I need to manually remove the previous ProductPackage entry and I lost field values such as the purpose

We could add an option to the "Add to Product", to enable automatic replacement of the ProductPackage entry, keeping some of the field values such as purpose.

This would only be applied in case there's 1 entry with the same purl (different version).

@DennisClark Let me know your thoughts on this.

@DennisClark
Copy link
Member

@tdruez Excellent idea !!! please pursue it, thanks.

@DennisClark DennisClark added this to the DejaCode 5.1 milestone Dec 8, 2023
tdruez added a commit that referenced this issue May 24, 2024
Signed-off-by: tdruez <tdruez@nexb.com>
tdruez added a commit that referenced this issue May 24, 2024
Signed-off-by: tdruez <tdruez@nexb.com>
tdruez added a commit that referenced this issue May 24, 2024
Signed-off-by: tdruez <tdruez@nexb.com>
tdruez added a commit that referenced this issue May 24, 2024
Signed-off-by: tdruez <tdruez@nexb.com>
tdruez added a commit that referenced this issue May 24, 2024
Signed-off-by: tdruez <tdruez@nexb.com>
tdruez added a commit that referenced this issue May 24, 2024
Signed-off-by: tdruez <tdruez@nexb.com>
tdruez added a commit that referenced this issue May 24, 2024
Signed-off-by: tdruez <tdruez@nexb.com>
tdruez added a commit that referenced this issue May 27, 2024
Signed-off-by: tdruez <tdruez@nexb.com>
tdruez added a commit that referenced this issue May 27, 2024
Signed-off-by: tdruez <tdruez@nexb.com>
tdruez added a commit that referenced this issue May 27, 2024
Signed-off-by: tdruez <tdruez@nexb.com>
tdruez added a commit that referenced this issue May 27, 2024
Signed-off-by: tdruez <tdruez@nexb.com>
tdruez added a commit that referenced this issue May 27, 2024
@DennisClark
Copy link
Member

Hi @tdruez I don't see the new option on Staging yet. Please investigate. In Staging Starship, I'm trying to replace
pkg:pypi/selenium@3.141.0
with
pkg:pypi/selenium@4.21.0
on Product Astrolabe 2.5.8
but the behavior is the same as before.

@tdruez
Copy link
Contributor Author

tdruez commented May 29, 2024

@DennisClark The feature is only available when selecting 1 or more Packages from the list and using the "Add to Product" action.

I'm not sure how we would be able to add this to the single package "Add to product" form that displays a complex form including all the relationship fields without a value.
Assuming the user would set any of those fields and select the "replace existing version", how would we deal with those values? It's unlikely that the user knows about any existing values on the existing version, overriding may be unwanted.

@DennisClark
Copy link
Member

@tdruez thanks fro the explanation; I'll give it another try.

@DennisClark
Copy link
Member

@tdruez looks good in Staging Starship, and the explanatory text for the new capability is excellent. thanks.

@tdruez tdruez closed this as completed Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants