Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add full purl to most screens #115

Closed
mjherzog opened this issue May 13, 2024 · 6 comments
Closed

Add full purl to most screens #115

mjherzog opened this issue May 13, 2024 · 6 comments
Assignees
@DennisClark
Labels
design needed Design details needed to complete the issue enhancement New feature or request MedPriority Medium Priority

Comments

@mjherzog
Copy link
Member

DejaCode should display the full purl in the Product/Inventory, Packages and Product/Compare screens and possibly other DejaCode screens. My recollection is that we streamlined the display to type/namespace/name/version for simplicity but as we work more with Packages data (esp. from Linux or other distros) it is very important to be able to see the qualifier and subpath if present.

This will make the screens more directly informative and make it much easier to compare Packages.
@mjherzog mjherzog added enhancement New feature or request design needed Design details needed to complete the issue MedPriority Medium Priority labels May 13, 2024
@tdruez
Copy link
Contributor

tdruez commented May 14, 2024

See also #18

tdruez added a commit that referenced this issue May 14, 2024
@tdruez
Always display the full Package URL including pkg: #115
213bd4f 
Signed-off-by: tdruez <tdruez@nexb.com>
tdruez added a commit that referenced this issue May 14, 2024
@tdruez
Always display the full Package URL including pkg: #115 (#118)
b339542 
Signed-off-by: tdruez <tdruez@nexb.com>
@tdruez
Copy link
Contributor

tdruez commented May 14, 2024

The full PURL including the "pkg:" prefix is now used everywhere in the DejaCode UI.

@tdruez tdruez closed this as completed May 14, 2024
@DennisClark
Copy link
Member

Updates confirmed, thanks @tdruez

@DennisClark
Copy link
Member

DennisClark commented May 20, 2024 •
edited
Loading

@tdruez The Packages list user view is showing the PURL, but the Qualifiers are not being displayed there. Can you please investigate. Also, the Qualifiers are not being shown on the Product Inventory form. (Sorry if I gave the all-clear too quickly.)

@DennisClark DennisClark reopened this May 20, 2024
tdruez added a commit that referenced this issue May 21, 2024
@tdruez
Display the full Package URL including qualifiers and subpath #115
d1e8716 
Signed-off-by: tdruez <tdruez@nexb.com>
@DennisClark
Copy link
Member

@tdruez Fixes confirmed in Staging Projects dataspace. This time I tested all the purl fields. Thanks very much!

tdruez added a commit that referenced this issue May 21, 2024
@tdruez
Display the full Package URL including qualifiers and subpath #115 (#123
68964a6 
)

Signed-off-by: tdruez <tdruez@nexb.com>
@tdruez
Copy link
Contributor

tdruez commented May 21, 2024

Fix deployed.

@tdruez tdruez closed this as completed May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DennisClark DennisClark

Labels
design needed Design details needed to complete the issue enhancement New feature or request MedPriority Medium Priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tdruez @mjherzog @DennisClark